From a87372a9b23063b8cf3af3c26dcf5de3a9ece8ee Mon Sep 17 00:00:00 2001
From: daniquilez <dani.quilez@gmail.com>
Date: Fri, 7 Mar 2025 15:47:43 +0100
Subject: [PATCH] =?UTF-8?q?[FIX]=20=F0=9F=90=9B=20Avoid=20creation=20of=20?=
 =?UTF-8?q?2=20sale=20orders?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../components/sale_order_utils.py                        | 8 +++++---
 .../views/contract_views.xml                              | 1 +
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/energy_communities_service_invoicing/components/sale_order_utils.py b/energy_communities_service_invoicing/components/sale_order_utils.py
index d5bdbe3ee..24c5ae56f 100644
--- a/energy_communities_service_invoicing/components/sale_order_utils.py
+++ b/energy_communities_service_invoicing/components/sale_order_utils.py
@@ -38,13 +38,15 @@ class SaleOrderUtils(Component):
         if payment_mode_id:
             so_creation_dict["payment_mode_id"] = payment_mode_id.id
         # Apply configuration sales team to service invoicing sales order
-        if company_id.service_invoicing_sale_team_id:
-            so_creation_dict["team_id"] = company_id.service_invoicing_sale_team_id.id
+        if self.env.company.service_invoicing_sale_team_id:
+            so_creation_dict[
+                "team_id"
+            ] = self.env.company.service_invoicing_sale_team_id.id
         sale_order = self.env["sale.order"].create(so_creation_dict)
         # Trigger name computattion in oder to include product's description_sale
         for order_line in sale_order.order_line:
             order_line._compute_name()
-        return self.env["sale.order"].create(so_creation_dict)
+        return sale_order
 
     def _create_service_invoicing(
         self,
diff --git a/energy_communities_service_invoicing/views/contract_views.xml b/energy_communities_service_invoicing/views/contract_views.xml
index e0f63f4e5..6e79bb912 100644
--- a/energy_communities_service_invoicing/views/contract_views.xml
+++ b/energy_communities_service_invoicing/views/contract_views.xml
@@ -93,6 +93,7 @@
       </xpath>
       <xpath expr="//field[@name='pricelist_id']" position="after">
         <field name="pack_id" />
+        <field name="pack_type" />
       </xpath>
       <xpath expr="//field[@name='user_id']" position="after">
         <field name="date_start" />
-- 
GitLab