Skip to content
Snippets Groups Projects
  • jvm-odoo's avatar
    d8dc4cba
    [FIX] web_tour: fix too much tips on appswitcher · d8dc4cba
    jvm-odoo authored
    
    Issue
    
    	- Deactivate demo data
    	- Install several modules (e.g. Sales, Helpdesk)
    	- Go on Home
    	- Hard refresh
    
    	All tours' tips are shown
    
    Cause
    
    	In 02dab5dc, we wait the DOM to be ready.
    	The DOM wasn't ready in previous version, this is
    	why it seems to work.
    
    	As the DOM is ready, in check_for_tooltip we
    	have a visible trigger so trigerred = true
    	and the tip is activated.
    
    	If you activate the debug mode, the DOM is
    	not ready too, this is why it works fine
    	in debug mode.
    
    Solution
    
    	I don't think that not waiting the DOM to be
    	ready is good so I think we should keep that
    	and handle the case when we update the tours
    	from the _register method. So that, we use
    	the else part of the update method which
    	will break after a tip has been activated.
    
    OPW-2188525
    
    closes odoo/odoo#45073
    
    X-original-commit: 5f0451c5
    Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
    d8dc4cba
    History
    [FIX] web_tour: fix too much tips on appswitcher
    jvm-odoo authored
    
    Issue
    
    	- Deactivate demo data
    	- Install several modules (e.g. Sales, Helpdesk)
    	- Go on Home
    	- Hard refresh
    
    	All tours' tips are shown
    
    Cause
    
    	In 02dab5dc, we wait the DOM to be ready.
    	The DOM wasn't ready in previous version, this is
    	why it seems to work.
    
    	As the DOM is ready, in check_for_tooltip we
    	have a visible trigger so trigerred = true
    	and the tip is activated.
    
    	If you activate the debug mode, the DOM is
    	not ready too, this is why it works fine
    	in debug mode.
    
    Solution
    
    	I don't think that not waiting the DOM to be
    	ready is good so I think we should keep that
    	and handle the case when we update the tours
    	from the _register method. So that, we use
    	the else part of the update method which
    	will break after a tip has been activated.
    
    OPW-2188525
    
    closes odoo/odoo#45073
    
    X-original-commit: 5f0451c5
    Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>