From 068d4c487e02f2e727f953b1bb130a20bced4c77 Mon Sep 17 00:00:00 2001 From: Raphael Collet <rco@openerp.com> Date: Wed, 6 Aug 2014 11:40:03 +0200 Subject: [PATCH] [IMP] models: name_search() should call _name_search() This avoids code duplication between methods, and keeps backward compatibility with existing code overriding _name_search(). --- openerp/models.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/openerp/models.py b/openerp/models.py index 5280117c0d93..8beb60d53b71 100644 --- a/openerp/models.py +++ b/openerp/models.py @@ -1729,12 +1729,7 @@ class BaseModel(object): :rtype: list :return: list of pairs ``(id, text_repr)`` for all matching records. """ - args = list(args or []) - if not self._rec_name: - _logger.warning("Cannot execute name_search, no _rec_name defined on %s", self._name) - elif not (name == '' and operator == 'ilike'): - args += [(self._rec_name, operator, name)] - return self.search(args, limit=limit).name_get() + return self._name_search(name, args, operator, limit=limit) def _name_search(self, cr, user, name='', args=None, operator='ilike', context=None, limit=100, name_get_uid=None): # private implementation of name_search, allows passing a dedicated user -- GitLab