From 16fc9e23adc2b91b163873293ccea99f4fb1850d Mon Sep 17 00:00:00 2001
From: hmai <hmai@odoo.com>
Date: Mon, 7 Aug 2023 13:07:47 +0200
Subject: [PATCH] [FIX] web editor: animation triggered on every backspace
This commit fixes the issue of animations that got trigger by backspacing, pressing enter
and other causes
The cause of the issue was a custom historyRevert event that was only used to
trigger a widgets_start_request event which ended up restarting the options,
which lead to the animation option replaying the animation.
We were not able to pinpoint the use of this particular trigger_up as it does
not seem to serve any purpose anymore. Since its presence does create a bug, we
decided that the best course of action was to remove it. If this commit creates
a regression and the original bug comes back, we will reassess the situation.
Task-2752421
closes odoo/odoo#131026
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
---
addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js | 1 -
addons/web_editor/static/src/js/editor/snippets.editor.js | 6 ------
2 files changed, 7 deletions(-)
diff --git a/addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js b/addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js
index 591eb642d43c..23d50dcc633c 100644
--- a/addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js
+++ b/addons/web_editor/static/lib/odoo-editor/src/OdooEditor.js
@@ -1003,7 +1003,6 @@ export class OdooEditor extends EventTarget {
this._activateContenteditable();
}
this.historySetSelection(step);
- this.dispatchEvent(new Event('historyRevert'));
}
}
/**
diff --git a/addons/web_editor/static/src/js/editor/snippets.editor.js b/addons/web_editor/static/src/js/editor/snippets.editor.js
index 8cab048f4520..e320bd555cfd 100644
--- a/addons/web_editor/static/src/js/editor/snippets.editor.js
+++ b/addons/web_editor/static/src/js/editor/snippets.editor.js
@@ -1550,12 +1550,6 @@ var SnippetsMenu = Widget.extend({
this.options.wysiwyg.odooEditor.addEventListener('observerApply', () => {
$(this.options.wysiwyg.odooEditor.editable).trigger('content_changed');
});
- this.options.wysiwyg.odooEditor.addEventListener('historyRevert', _.debounce(() => {
- this.trigger_up('widgets_start_request', {
- $target: this.options.wysiwyg.$editable,
- editableMode: true,
- });
- }, 50));
}
// Trigger a resize event once entering edit mode as the snippets
--
GitLab