From 3154b8fefcdce0c13b657428b7129cb976de59ed Mon Sep 17 00:00:00 2001
From: Martin Trigaux <mat@odoo.com>
Date: Wed, 12 Oct 2016 16:26:03 +0200
Subject: [PATCH] [IMP] base: clarify view error position

In case of syntax error, show where the error is.
e.message is enmpty for syntax errors

Before:
Can't validate view:

After:
Can't validate view:
SyntaxError('invalid syntax', ('', 1, 51, "{'invisible': [('external_sale', '=', 'internal')]]}"))
---
 odoo/addons/base/ir/ir_ui_view.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odoo/addons/base/ir/ir_ui_view.py b/odoo/addons/base/ir/ir_ui_view.py
index 67c755581d32..fb86fcf26014 100644
--- a/odoo/addons/base/ir/ir_ui_view.py
+++ b/odoo/addons/base/ir/ir_ui_view.py
@@ -1168,4 +1168,4 @@ actual arch.
             try:
                 self.browse(vid)._check_xml()
             except Exception as e:
-                self.raise_view_error("Can't validate view: %s" % e.message, vid)
+                self.raise_view_error("Can't validate view:\n%s" % (e.message or repr(e)), vid)
-- 
GitLab