From 440c5d6e443add49018b4615afe5a08613284bc3 Mon Sep 17 00:00:00 2001
From: Martin Trigaux <mat@odoo.com>
Date: Thu, 2 Jun 2016 12:19:36 +0200
Subject: [PATCH] [FIX] subscription: avoid trying to access to subscriptions
without cron
The cron may no longer be present (e.g. deleted) and the subscribtion would be
blocked in running state.
Fixes #12207
---
addons/subscription/subscription.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/addons/subscription/subscription.py b/addons/subscription/subscription.py
index 9a5781d2ddd7..d06d601840d9 100644
--- a/addons/subscription/subscription.py
+++ b/addons/subscription/subscription.py
@@ -130,8 +130,9 @@ class subscription_subscription(osv.osv):
def set_done(self, cr, uid, ids, context=None):
res = self.read(cr,uid, ids, ['cron_id'])
- ids2 = [x['cron_id'][0] for x in res if x['id']]
- self.pool.get('ir.cron').write(cr, uid, ids2, {'active':False})
+ ids2 = [x['cron_id'][0] for x in res if x['cron_id']]
+ if ids2:
+ self.pool.get('ir.cron').write(cr, uid, ids2, {'active':False})
self.write(cr, uid, ids, {'state':'done'})
return True
--
GitLab