From 4c030311ada2ad19a2ee81b15544b7aed35b642b Mon Sep 17 00:00:00 2001 From: Kevin Baptiste <kba@odoo.com> Date: Tue, 26 Nov 2019 10:26:17 +0000 Subject: [PATCH] [FIX] ratings: properly convert rating closes odoo/odoo#40853 Taskid: 2145481 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com> --- addons/rating/controllers/main.py | 2 +- addons/rating/views/rating_template.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/rating/controllers/main.py b/addons/rating/controllers/main.py index 5257073ce7b9..5c1f7f5f4ce0 100644 --- a/addons/rating/controllers/main.py +++ b/addons/rating/controllers/main.py @@ -29,7 +29,7 @@ class Rating(http.Controller): @http.route(['/rating/<string:token>/submit_feedback'], type="http", auth="public", methods=['post'], website=True) def submit_rating(self, token, **kwargs): - rate = kwargs.get('rate') + rate = int(kwargs.get('rate')) assert rate in (1, 5, 10), "Incorrect rating" rating = request.env['rating.rating'].sudo().search([('access_token', '=', token)]) if not rating: diff --git a/addons/rating/views/rating_template.xml b/addons/rating/views/rating_template.xml index 679db3ede20c..5b9552e2ffc8 100644 --- a/addons/rating/views/rating_template.xml +++ b/addons/rating/views/rating_template.xml @@ -25,7 +25,7 @@ <div class="btn-group btn-group-toggle row" data-toggle="buttons"> <t t-foreach="rate_names" t-as="rate_name"> <label t-attf-class="col-xs-12 btn o_rating_label shadow-none {{rate == rate_name and 'active' or ''}}"> - <input type="radio" name="rate" t-attf-id="rate_{{rate_name}}" t-att-value="rate_name"/> + <input type="radio" name="rate" t-attf-id="rate_{{rate_name}}" t-att-value="rate_name" t-att-checked="rate == rate_name"/> <a class="o_rating" href="#"> <img t-attf-src='/rating/static/src/img/rating_#{rate_name}.png' t-att-alt="rate_name_value" t-att-title="rate_name_value"/> </a> -- GitLab