From 58cd10eb7277312d7d6c5e9da7b52dcbdb114734 Mon Sep 17 00:00:00 2001
From: "Tiffany Chang (tic)" <tic@odoo.com>
Date: Thu, 28 Oct 2021 08:54:59 +0000
Subject: [PATCH] [FIX] mrp: allow backorder immediate production for SN
product
Steps to reproduce:
1. Create Manufacturing Order with quantity >1 of Serial Tracked product
2. Press Mark done. (One Product will be immediated produced with a new
SN auto-created)
3. Create Backorder
4. Press Mark done on the backorder
Expected Result:
Backorder will also be able to immediate produce and auto-create a new SN
Actual Result:
Usererror because env is still referring to original MO and tries to
produce the same SN again.
closes odoo/odoo#79123
Fixes: odoo/odoo#78134
Signed-off-by: Arnold Moyaux <arm@odoo.com>
---
addons/mrp/models/mrp_production.py | 2 +-
addons/mrp/tests/test_backorder.py | 29 +++++++++++++++++++++++++++++
2 files changed, 30 insertions(+), 1 deletion(-)
diff --git a/addons/mrp/models/mrp_production.py b/addons/mrp/models/mrp_production.py
index cfd9383a5d55..7b03ec6a9478 100644
--- a/addons/mrp/models/mrp_production.py
+++ b/addons/mrp/models/mrp_production.py
@@ -1555,7 +1555,7 @@ class MrpProduction(models.Model):
action = {
'res_model': 'mrp.production',
'type': 'ir.actions.act_window',
- 'context': dict(context, mo_ids_to_backorder=None)
+ 'context': dict(context, mo_ids_to_backorder=None, button_mark_done_production_ids=None)
}
if len(backorders) == 1:
action.update({
diff --git a/addons/mrp/tests/test_backorder.py b/addons/mrp/tests/test_backorder.py
index 294bd528fad0..ae181e228eac 100644
--- a/addons/mrp/tests/test_backorder.py
+++ b/addons/mrp/tests/test_backorder.py
@@ -280,6 +280,35 @@ class TestMrpProductionBackorder(TestMrpCommon):
self.assertEqual(self.env['stock.quant']._get_available_quantity(p_final, self.stock_location), nb_product_todo, f'You should have the {nb_product_todo} final product in stock')
self.assertEqual(len(production.procurement_group_id.mrp_production_ids), nb_product_todo)
+ def test_tracking_backorder_immediate_production_serial_1(self):
+ """ Create a MO to build 2 of a SN tracked product.
+ Build both the starting MO and its backorder as immediate productions
+ (i.e. Mark As Done without setting SN/filling any quantities)
+ """
+ mo, _, p_final, p1, p2 = self.generate_mo(qty_final=2, tracking_final='serial', qty_base_1=2, qty_base_2=2)
+ self.env['stock.quant']._update_available_quantity(p1, self.stock_location_components, 2.0)
+ self.env['stock.quant']._update_available_quantity(p2, self.stock_location_components, 2.0)
+ mo.action_assign()
+ res_dict = mo.button_mark_done()
+ self.assertEqual(res_dict.get('res_model'), 'mrp.immediate.production')
+ immediate_wizard = Form(self.env[res_dict['res_model']].with_context(res_dict['context'])).save()
+ res_dict = immediate_wizard.process()
+ self.assertEqual(res_dict.get('res_model'), 'mrp.production.backorder')
+ backorder_wizard = Form(self.env[res_dict['res_model']].with_context(res_dict['context']))
+
+ # backorder should automatically open
+ action = backorder_wizard.save().action_backorder()
+ self.assertEqual(action.get('res_model'), 'mrp.production')
+ backorder_mo_form = Form(self.env[action['res_model']].with_context(action['context']).browse(action['res_id']))
+ backorder_mo = backorder_mo_form.save()
+ res_dict = backorder_mo.button_mark_done()
+ self.assertEqual(res_dict.get('res_model'), 'mrp.immediate.production')
+ immediate_wizard = Form(self.env[res_dict['res_model']].with_context(res_dict['context'])).save()
+ immediate_wizard.process()
+
+ self.assertEqual(self.env['stock.quant']._get_available_quantity(p_final, self.stock_location), 2, "Incorrect number of final product produced.")
+ self.assertEqual(len(self.env['stock.production.lot'].search([('product_id', '=', p_final.id)])), 2, "Serial Numbers were not correctly produced.")
+
def test_backorder_name(self):
def produce_one(mo):
mo_form = Form(mo)
--
GitLab