From 5d40023eaf9b3c25941429e7fac266722780846d Mon Sep 17 00:00:00 2001 From: Xavier-Do <xdo@odoo.com> Date: Tue, 20 Jul 2021 12:51:09 +0000 Subject: [PATCH] [REM] codeowner: remove github codeowner MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Github codeowner is replaced with a runbot version of codeowners for multiple reason: - github codeowners is difficult to maintain, the precedence rule will sometimes remove teams from some file because of a more specific rule added by another team. - github codeowner does not support version specific rules, especially the "all except master" rule. For this use case teams needs to adapt the new codeowner when freezing a new version. - github will trigger codeowner on failed rebase, and add almost all teams as reviewer. Runbot has specific commit and file limit to avoid this problem. - runbot codeowner is centralised and does not need to be managed cross repo/version - runbot codeowner works for enterprise Any mofification on codeowner should be requested to runbot team. closes odoo/odoo#74094 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com> --- .github/CODEOWNERS | 145 --------------------------------------------- 1 file changed, 145 deletions(-) delete mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index a3fc39d0903b..000000000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,145 +0,0 @@ -# Doc: https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners -# Order is important; the last matching pattern takes the most precedence. - -# Please apply the following guidelines when updating this file. - -# Paths and patterns -# ================== - -# Paths should be ordered alphabetically (when precedence is not an issue). -# Avoid complex patterns, prefer full path targeting files or directories. - -# When creating a more specific pattern of an existing more generic pattern: -# - The specific pattern must be listed below. -# - Teams and users of the generic pattern have to be copied to the specific -# pattern, unless they approve to lose their ownership for the paths matched -# by the specific pattern. - -# Teams and users -# =============== - -# Prefer using teams whenever possible, as members of teams and review -# assignation rules can be dynamically managed outside of this file without -# requiring a new commit. -# Only define users for specific cases. -# For each pattern: list teams first, then users, both alphabetically. - -# Listed teams and users must have write permissions on the repository for the -# feature to work. - - -# Generic fallback rules - -/addons/account*/ @odoo/rd-accounting -/addons/crm*/ @odoo/rd-sm -/addons/event*/ @odoo/rd-sm -/addons/l10n_*/ @odoo/rd-accounting -/addons/*/data/mail_template_data.xml @odoo/rd-sm -/addons/*/models/ir_http.py @odoo/rd-website -/addons/*/models/ir_qweb.py @odoo/rd-website -/addons/*/models/ir_qweb_fields.py @odoo/rd-website -/addons/website*/ @odoo/rd-website -/addons/website_event*/ @odoo/rd-notif-muted @odoo/rd-sm -/addons/website_slides*/ @odoo/rd-notif-muted @odoo/rd-sm - - -# Specific rules - -/.github/CODEOWNERS @odoo/rd-code-owners - -/addons/bus/ @odoo/rd-framework-js - -/addons/http_routing/ @odoo/rd-website - -/addons/im_livechat/ @odoo/rd-discuss - -/addons/mail/ @odoo/rd-discuss -/addons/mail/**/*.py @odoo/rd-discuss @odoo/rd-sm -/addons/mail/models/ir_http.py @odoo/rd-discuss @odoo/rd-website - -/addons/mail_bot/ @odoo/rd-discuss -/addons/mail_bot/models/ir_http.py @odoo/rd-discuss @odoo/rd-website - -/addons/mass_mailing/**/*.py @odoo/rd-sm - -/addons/mrp/ @odoo/rd-logistics -/addons/mrp_account/ @odoo/rd-logistics - -/addons/phone_validation/ @odoo/rd-sm - -/addons/portal/models/ir_http.py @odoo/rd-website - -/addons/product_expiry/ @odoo/rd-logistics - -/addons/purchase/ @odoo/rd-logistics -/addons/purchase_mrp/ @odoo/rd-logistics -/addons/purchase_requisition/ @odoo/rd-logistics -/addons/purchase_stock/ @odoo/rd-logistics - -/addons/rating/**/*.py @odoo/rd-sm - -/addons/repair/ @odoo/rd-logistics - -/addons/sale_mrp/ @odoo/rd-logistics -/addons/sale_purchase/ @odoo/rd-logistics -/addons/sale_stock/ @odoo/rd-logistics - -/addons/sms/ @odoo/rd-discuss -/addons/sms/**/*.py @odoo/rd-discuss @odoo/rd-sm - -/addons/snailmail/ @odoo/rd-discuss -/addons/snailmail/models/ir_qweb_fields.py @odoo/rd-discuss @odoo/rd-website - -/addons/stock/ @odoo/rd-logistics -/addons/stock_account/ @odoo/rd-logistics -/addons/stock_dropshipping/ @odoo/rd-logistics -/addons/stock_landed_costs/ @odoo/rd-logistics -/addons/stock_picking_batch/ @odoo/rd-logistics - -/addons/test_mail/ @odoo/rd-discuss @odoo/rd-sm -/addons/test_mass_mailing/ @odoo/rd-sm -/addons/test_website/ @odoo/rd-website - -/addons/web/ @odoo/rd-framework-js -/addons/web/controllers/main.py @odoo/rd-framework-js @odoo/rd-images @odoo/rd-security -/addons/web/models/ir_qweb.py @odoo/rd-framework-js @odoo/rd-images @odoo/rd-website -/addons/web/tests/test_image.py @odoo/rd-images - -/addons/web_editor/models/ir_qweb.py @odoo/rd-website - -/addons/web_kanban_gauge/ @odoo/rd-framework-js - -/addons/web_unsplash/models/ir_qweb.py @odoo/rd-website - -/addons/website/models/ir_qweb.py @odoo/rd-website -/addons/website/models/ir_qweb_fields.py @odoo/rd-website - -/addons/website_livechat/ @odoo/rd-discuss @odoo/rd-website - -/addons/website_sale/tests/test_website_sale_image.py @odoo/rd-images @odoo/rd-website - -/odoo/addons/base/models/assetsbundle.py @odoo/rd-framework-js -/odoo/addons/base/models/ir_attachment.py @odoo/rd-images -/odoo/addons/base/models/ir_qweb.py @odoo/rd-website -/odoo/addons/base/models/ir_qweb_fields.py @odoo/rd-website -/odoo/addons/base/models/qweb.py @odoo/rd-website - -/odoo/addons/base/tests/test_image.py @odoo/rd-images -/odoo/addons/base/tests/test_ir_http.py @odoo/rd-website - -/odoo/cli/ts_config.py @odoo/rd-framework-js - -/odoo/modules/migration.py @odoo/upgrade - -# expression, query -/odoo/osv/ @odoo/rd-security - -# safe_eval, mimetypes, float_utils, mail sanitizer, image utils, .. -/odoo/tools/ @odoo/rd-security -/odoo/tools/image.py @odoo/rd-images @odoo/rd-security -/odoo/tools/js_transpiler.py @odoo/rd-framework-js @odoo/rd-security -/odoo/tools/mimetypes.py @odoo/rd-images @odoo/rd-security -/odoo/tools/sourcemap_generator.py @odoo/rd-framework-js @odoo/rd-security - -/odoo/http.py @odoo/rd-security @odoo/rd-website -/odoo/sql_db.py @odoo/rd-security -- GitLab