From 5dca782100ae156a8a5c778092d1da9c0d5d7edc Mon Sep 17 00:00:00 2001
From: Christophe Simonis <chs@odoo.com>
Date: Mon, 16 Apr 2018 20:26:21 +0200
Subject: [PATCH] Revert "[FIX] web: remove &shy; when saving phone number"

This reverts commit b8b0f947bf7f7abf930a1797fa55c7f7dd33faa2.
---
 addons/web/static/src/js/fields/basic_fields.js   | 15 ---------------
 .../web/static/tests/fields/basic_fields_tests.js | 11 +----------
 2 files changed, 1 insertion(+), 25 deletions(-)

diff --git a/addons/web/static/src/js/fields/basic_fields.js b/addons/web/static/src/js/fields/basic_fields.js
index c703694a9d4f..0f426dedd3b7 100644
--- a/addons/web/static/src/js/fields/basic_fields.js
+++ b/addons/web/static/src/js/fields/basic_fields.js
@@ -998,21 +998,6 @@ var FieldPhone = FieldEmail.extend({
         // important right now.
         this.$el.removeClass('o_text_overflow');
     },
-     * Remove possibly present &shy; characters when saving number
-     *
-     * @override
-     * @private
-     */
-    _setValue: function (value, options) {
-        // NOT NEEDED AS OF SAAS-11.3
-        if (value) {
-            // remove possibly pasted &shy; characters
-            value = value.replace(/\u00AD/g, '');
-        }
-        return this._super(value, options);
-    },
-
-    /**
 });
 
 var UrlWidget = InputField.extend({
diff --git a/addons/web/static/tests/fields/basic_fields_tests.js b/addons/web/static/tests/fields/basic_fields_tests.js
index ff60e6394219..6aa28fd9a2ef 100644
--- a/addons/web/static/tests/fields/basic_fields_tests.js
+++ b/addons/web/static/tests/fields/basic_fields_tests.js
@@ -3145,7 +3145,7 @@ QUnit.module('basic_fields', {
     QUnit.module('PhoneWidget');
 
     QUnit.test('phone field in form view on extra small screens', function (assert) {
-        assert.expect(8);
+        assert.expect(7);
 
         var form = createView({
             View: FormView,
@@ -3192,15 +3192,6 @@ QUnit.module('basic_fields', {
         assert.strictEqual($phoneLink.attr('href'), 'tel:new',
             "should still have proper tel prefix");
 
-        // NOT NEEDED AS OF SAAS-11.3
-        // save phone with &shy; and verify it is removed
-        form.$buttons.find('.o_form_button_edit').click();
-        form.$('input[type="text"].o_field_widget').val('h\u00ADi').trigger('input');
-        form.$buttons.find('.o_form_button_save').click();
-        $phoneLink = form.$('a.o_form_uri.o_field_widget');
-        assert.strictEqual($phoneLink.attr('href'), 'tel:hi',
-            "U+00AD should have been removed");
-
         form.destroy();
     });
 
-- 
GitLab