From 661ab67c1e05f27aee0ea805d44b3a5412b13ff5 Mon Sep 17 00:00:00 2001
From: Joseph Caburnay <jcb@odoo.com>
Date: Wed, 17 May 2023 08:52:58 +0000
Subject: [PATCH] [FIX] point_of_sale: random runbot error (20517)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
When performing the picking action in the context of savepoint, the env
inside the action can randomly change causing an AccessError which is
caught as UserError (in the current point_of_sale code). Flushing before
calling a method in a savepoint will deterministically avoid this issue.
Note that the weakset used to store environments was modified in #121604
to avoid this kind of issue.
When using a cr.savepoint, the transaction must be flushed but in we
don't have any reference to the env that should be used on the cursor,
meaning that the env is chosen in the list of existing env. This choice
is random because Transaction.envs is using a Weakset.
In some case, the chosen env does not have the correct access right
because the context allowed_company_ids is corresponding to a company
coming from another test, leading to an access error, hidden by the try
except.
Flushing the environment before creating the savepoint will help to
prevent this issue by flushing on a well defined environment.
Note that the weakset used to store environments was modified in #121604
(master)
closes odoo/odoo#121849
X-original-commit: 211f2fcef5e9363cb9eef294fcdfb4b90fbefa43
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
---
addons/point_of_sale/models/stock_picking.py | 2 ++
addons/stock/models/stock_move.py | 1 +
2 files changed, 3 insertions(+)
diff --git a/addons/point_of_sale/models/stock_picking.py b/addons/point_of_sale/models/stock_picking.py
index 21fecc2e6f17..f04d9a44ba2e 100644
--- a/addons/point_of_sale/models/stock_picking.py
+++ b/addons/point_of_sale/models/stock_picking.py
@@ -43,6 +43,7 @@ class StockPicking(models.Model):
)
positive_picking._create_move_from_pos_order_lines(positive_lines)
+ self.env.flush_all()
try:
with self.env.cr.savepoint():
positive_picking._action_done()
@@ -62,6 +63,7 @@ class StockPicking(models.Model):
self._prepare_picking_vals(partner, return_picking_type, location_dest_id, return_location_id)
)
negative_picking._create_move_from_pos_order_lines(negative_lines)
+ self.env.flush_all()
try:
with self.env.cr.savepoint():
negative_picking._action_done()
diff --git a/addons/stock/models/stock_move.py b/addons/stock/models/stock_move.py
index 791299e6a1d0..0c063222318f 100644
--- a/addons/stock/models/stock_move.py
+++ b/addons/stock/models/stock_move.py
@@ -1494,6 +1494,7 @@ Please change the quantity done or the rounding precision of your unit of measur
if float_compare(taken_quantity, int(taken_quantity), precision_digits=rounding) != 0:
taken_quantity = 0
+ self.env.flush_all()
try:
with self.env.cr.savepoint():
if not float_is_zero(taken_quantity, precision_rounding=self.product_id.uom_id.rounding):
--
GitLab