From 76711686a261cf0c42110902ab426756c5d43608 Mon Sep 17 00:00:00 2001
From: krha-odoo <krha@odoo.com>
Date: Thu, 15 Sep 2022 09:32:53 +0000
Subject: [PATCH] [FIX] sale: fix duplicated `sale.report` ids
Before this commit, when point of sale order line (in table pos_order_line, Point of Sale app) and empty sale order (in table sale_order, Sales app) shares the same id number, it may create duplicate id in sale_report sql view. Empty sale order is an order with no products, so not connected to sale order line.
Additionally, these duplicates creates some discrepancies between pivot and list view in sale report in Sales app.
This commit fixes the issue by removing sale orders with no order lines.
Steps to reproduce the issue:
-----------------------------
1. Create order in Point of Sale app with minimum pos_order_line id equal to "n"
2. Create empty sale order (no order lines inside) with id equal to "n"
To reproduce issue on runbot, one may check the minimum order line for one of pos orders (assume this is n) and then delete all order lines from sale order with id equal to n.
Current behavior:
----------------------------
There will be two lines in sale_repot sql view with id equal to "-n"
Expected behavior:
----------------------------
Id in sale_report view should be unique
opw-2946444
closes odoo/odoo#105303
X-original-commit: a48d3fedd833768bce292bcb52dcb8d3baf4a291
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
---
addons/sale/report/sale_report.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/addons/sale/report/sale_report.py b/addons/sale/report/sale_report.py
index bcc2c2a204d8..91fb8fcf92ab 100644
--- a/addons/sale/report/sale_report.py
+++ b/addons/sale/report/sale_report.py
@@ -63,7 +63,7 @@ class SaleReport(models.Model):
def _select_sale(self):
select_ = f"""
- COALESCE(min(l.id), -s.id) AS id,
+ MIN(l.id) AS id,
l.product_id AS product_id,
t.uom_id AS product_uom,
CASE WHEN l.product_id IS NOT NULL THEN SUM(l.product_uom_qty / u.factor * u2.factor) ELSE 0 END AS product_uom_qty,
@@ -141,7 +141,7 @@ class SaleReport(models.Model):
def _from_sale(self):
return """
sale_order_line l
- RIGHT OUTER JOIN sale_order s ON s.id=l.order_id
+ LEFT JOIN sale_order s ON s.id=l.order_id
JOIN res_partner partner ON s.partner_id = partner.id
LEFT JOIN product_product p ON l.product_id=p.id
LEFT JOIN product_template t ON p.product_tmpl_id=t.id
--
GitLab