From 8e5196eff0ea77fa0a19e1f176d212f148a036da Mon Sep 17 00:00:00 2001
From: "Thomas Lefebvre (thle)" <thle@odoo.com>
Date: Mon, 31 Oct 2022 14:53:47 +0000
Subject: [PATCH] [FIX] calendar: create an appraisal directly by editing it
Steps to reproduce:
- get into an employee appraisal;
- click on the smart button "No meeting" from calendar view;
- edit it directly the meeting and save.
Issue:
We will not find any new meeting on the smart button if we go back to the employee appraisal page.
Cause:
When saving the appraisal from the edit view, an event will be created. Unfortunately, the `res_id` field (which allows it to be linked to a record in the `hr_appraisal` table) is not correct. The smart button that is attached to the `hr_appraisal` model will not detect that there is an event.
Solution:
Don't accept a `res_id` which is zero. If so, take the default `res_id` and update it in the dictionnary that will be used to create the event.
opw-3042573
closes odoo/odoo#104627
Related: odoo/enterprise#33510
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
addons/calendar/models/calendar_event.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/addons/calendar/models/calendar_event.py b/addons/calendar/models/calendar_event.py
index 688331f2bd3d..c28db05c3a00 100644
--- a/addons/calendar/models/calendar_event.py
+++ b/addons/calendar/models/calendar_event.py
@@ -742,7 +742,7 @@ class Meeting(models.Model):
if values.get('activity_ids'):
continue
res_model_id = values.get('res_model_id', defaults.get('res_model_id'))
- res_id = values.get('res_id', defaults.get('res_id'))
+ values['res_id'] = res_id = values.get('res_id') or defaults.get('res_id')
user_id = values.get('user_id', defaults.get('user_id'))
if not res_model_id or not res_id:
continue
--
GitLab