From 92e266e65c8bbe4d02fe138365ebf34a15eef798 Mon Sep 17 00:00:00 2001
From: "Achraf (abz)" <abz@odoo.com>
Date: Tue, 17 Aug 2021 13:14:36 +0000
Subject: [PATCH] [FIX] stock: Don't set DO to ready if a move is empty
A stock move with 0 qty in initial demand is considered as 'ready'. But
those stock moves should be excluded of the picking state computation to
not false the readiness of the picking, especially if the delivery
policy is set to 'direct'.
opw-2611018
closes odoo/odoo#75194
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
---
addons/stock/models/stock_move.py | 4 +++-
addons/stock/tests/test_packing.py | 31 ++++++++++++++++++++++++++++++
2 files changed, 34 insertions(+), 1 deletion(-)
diff --git a/addons/stock/models/stock_move.py b/addons/stock/models/stock_move.py
index 89b49a67995b..f416614f01fe 100644
--- a/addons/stock/models/stock_move.py
+++ b/addons/stock/models/stock_move.py
@@ -629,8 +629,10 @@ class StockMove(models.Model):
'confirmed': 1,
}
moves_todo = self\
- .filtered(lambda move: move.state not in ['cancel', 'done'])\
+ .filtered(lambda move: move.state not in ['cancel', 'done'] and not (move.state == 'assigned' and not move.product_uom_qty))\
.sorted(key=lambda move: (sort_map.get(move.state, 0), move.product_uom_qty))
+ if not moves_todo:
+ return 'assigned'
# The picking should be the same for all moves.
if moves_todo[0].picking_id.move_type == 'one':
most_important_move = moves_todo[0]
diff --git a/addons/stock/tests/test_packing.py b/addons/stock/tests/test_packing.py
index cddf62a07b28..a8b0c77e3893 100644
--- a/addons/stock/tests/test_packing.py
+++ b/addons/stock/tests/test_packing.py
@@ -709,3 +709,34 @@ class TestPacking(TransactionCase):
{"qty_done": 0, "result_package_id": new_package.id},
],
)
+
+ def test_picking_state_with_null_qty(self):
+ receipt_form = Form(self.env['stock.picking'].with_context(default_immediate_transfer=False))
+ picking_type_id = self.warehouse.out_type_id
+ receipt_form.picking_type_id = picking_type_id
+ with receipt_form.move_ids_without_package.new() as move_line:
+ move_line.product_id = self.productA
+ move_line.product_uom_qty = 10
+ with receipt_form.move_ids_without_package.new() as move_line:
+ move_line.product_id = self.productB
+ move_line.product_uom_qty = 10
+ receipt = receipt_form.save()
+ receipt.action_confirm()
+ self.assertEqual(receipt.state, 'confirmed')
+ receipt.move_ids_without_package[1].product_uom_qty = 0
+ self.assertEqual(receipt.state, 'confirmed')
+
+ receipt_form = Form(self.env['stock.picking'].with_context(default_immediate_transfer=True))
+ picking_type_id = self.warehouse.out_type_id
+ receipt_form.picking_type_id = picking_type_id
+ with receipt_form.move_ids_without_package.new() as move_line:
+ move_line.product_id = self.productA
+ move_line.quantity_done = 10
+ with receipt_form.move_ids_without_package.new() as move_line:
+ move_line.product_id = self.productB
+ move_line.quantity_done = 10
+ receipt = receipt_form.save()
+ receipt.action_confirm()
+ self.assertEqual(receipt.state, 'assigned')
+ receipt.move_ids_without_package[1].product_uom_qty = 0
+ self.assertEqual(receipt.state, 'assigned')
--
GitLab