From aac60544541c40e9bc8eb711f3926a0852ddcf36 Mon Sep 17 00:00:00 2001
From: "Lucas Perais (lpe)" <lpe@odoo.com>
Date: Wed, 25 Sep 2019 09:17:34 +0000
Subject: [PATCH] [FIX] account: invoice, refund in foreign; payment, writeoff
in domestic reconcile
Have an exchange rate of 1.1106
Have an invoice and a refund in a foreign currency
(amounts: 800 and 400)
Have a payment and a writeoff in domestic currency
(amounts: 200 and 160.16))
Before this commit, the invoice was not fully reconciled
even though the whole chain was
This was because, when checking if we should fully reconcile
we did so by forgetting that some members of the reconciliation
chain has a foreign currency
So, the exchange rate difference was never posted
(which amounts to 0.01 in foreign currency, and 0.00 in domestic)
After this commit, all the chain is reconciled, including the invoice
OPW 2057845
closes odoo/odoo#37677
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
---
addons/account/tests/test_reconciliation.py | 59 +++++++++++++++++++++
1 file changed, 59 insertions(+)
diff --git a/addons/account/tests/test_reconciliation.py b/addons/account/tests/test_reconciliation.py
index 3f1536cdf145..436f5f390afd 100644
--- a/addons/account/tests/test_reconciliation.py
+++ b/addons/account/tests/test_reconciliation.py
@@ -2131,3 +2131,62 @@ class TestReconciliationExec(TestReconciliation):
to_reconcile.reconcile()
for aml in to_reconcile:
self.assertEqual(aml.amount_residual, 0.0)
+
+ def test_inv_refund_foreign_payment_writeoff_domestic2(self):
+ company = self.env.ref('base.main_company')
+ self.env['res.currency.rate'].search([]).unlink()
+ self.env['res.currency.rate'].create({
+ 'name': time.strftime('%Y') + '-07-01',
+ 'rate': 1.0,
+ 'currency_id': self.currency_euro_id,
+ 'company_id': company.id
+ })
+ self.env['res.currency.rate'].create({
+ 'name': time.strftime('%Y') + '-07-01',
+ 'rate': 1.110600, # Don't change this !
+ 'currency_id': self.currency_usd_id,
+ 'company_id': self.env.ref('base.main_company').id
+ })
+ inv1 = self.create_invoice(invoice_amount=800, currency_id=self.currency_usd_id)
+ inv2 = self.create_invoice(type="out_refund", invoice_amount=400, currency_id=self.currency_usd_id)
+
+ payment = self.env['account.payment'].create({
+ 'payment_method_id': self.inbound_payment_method.id,
+ 'payment_type': 'inbound',
+ 'partner_type': 'customer',
+ 'partner_id': inv1.partner_id.id,
+ 'amount': 200.00,
+ 'journal_id': self.bank_journal_euro.id,
+ 'company_id': company.id,
+ })
+ payment.post()
+
+ inv1_receivable = inv1.move_id.line_ids.filtered(lambda l: l.account_id.internal_type == 'receivable')
+ inv2_receivable = inv2.move_id.line_ids.filtered(lambda l: l.account_id.internal_type == 'receivable')
+ pay_receivable = payment.move_line_ids.filtered(lambda l: l.account_id.internal_type == 'receivable')
+
+ move_balance = self.env['account.move'].create({
+ 'partner_id': inv1.partner_id.id,
+ 'date': time.strftime('%Y') + '-07-01',
+ 'journal_id': self.bank_journal_euro.id,
+ 'line_ids': [
+ (0, False, {'credit': 160.16, 'account_id': inv1_receivable.account_id.id, 'name': 'Balance WriteOff'}),
+ (0, False, {'debit': 160.16, 'account_id': self.diff_expense_account.id, 'name': 'Balance WriteOff'}),
+ ]
+ })
+
+ move_balance.post()
+ move_balance_receiv = move_balance.line_ids.filtered(lambda l: l.account_id.internal_type == 'receivable')
+
+ (inv1_receivable + inv2_receivable + pay_receivable + move_balance_receiv).reconcile()
+
+ self.assertTrue(inv1_receivable.full_reconcile_id.exists())
+ self.assertEquals(inv1_receivable.full_reconcile_id, inv2_receivable.full_reconcile_id)
+ self.assertEquals(inv1_receivable.full_reconcile_id, pay_receivable.full_reconcile_id)
+ self.assertEquals(inv1_receivable.full_reconcile_id, move_balance_receiv.full_reconcile_id)
+
+ self.assertTrue(inv1.reconciled)
+ self.assertTrue(inv2.reconciled)
+
+ self.assertEquals(inv1.state, 'paid')
+ self.assertEquals(inv2.state, 'paid')
--
GitLab