From c1b10731ce1a7b32b670034b54993d8bdb31e554 Mon Sep 17 00:00:00 2001
From: Florian Damhaut <flda@odoo.com>
Date: Thu, 23 Dec 2021 10:56:39 +0000
Subject: [PATCH] [FIX] hr_fleet : UserError on empty pdf
Step to reproduce:
- Print a 'claim car report' on a car with no attachment
Current Behaviour:
- Print a empty PDF
Behaviour after PR:
- The landing page explain to the user there is no pdf to print
opw-2714493
closes odoo/odoo#81687
Signed-off-by: Damhaut Florian (flda) <flda@odoo.com>
---
addons/hr_fleet/controllers/main.py | 3 +++
addons/hr_fleet/i18n/hr_fleet.pot | 5 +++++
2 files changed, 8 insertions(+)
diff --git a/addons/hr_fleet/controllers/main.py b/addons/hr_fleet/controllers/main.py
index 80748991fda9..66eb3a18dff9 100644
--- a/addons/hr_fleet/controllers/main.py
+++ b/addons/hr_fleet/controllers/main.py
@@ -67,6 +67,9 @@ class HrFleet(Controller):
page.mergePage(header_pdf.getPage(0))
writer.addPage(page)
+ if not writer.getNumPages():
+ request.not_found(_('There is no pdf attached to generate a claim report.'))
+
_buffer = io.BytesIO()
writer.write(_buffer)
merged_pdf = _buffer.getvalue()
diff --git a/addons/hr_fleet/i18n/hr_fleet.pot b/addons/hr_fleet/i18n/hr_fleet.pot
index d92f9c796bc6..ed5dd988218c 100644
--- a/addons/hr_fleet/i18n/hr_fleet.pot
+++ b/addons/hr_fleet/i18n/hr_fleet.pot
@@ -118,6 +118,11 @@ msgid ""
"go on vehicle page. Do you want to proceed?"
msgstr ""
+#. module: hr_fleet
+#: code:addons/hr_fleet/controllers/main.py:0
+msgid "There is no pdf attached to generate a claim report."
+msgstr ""
+
#. module: hr_fleet
#: model:ir.model,name:hr_fleet.model_res_users
msgid "Users"
--
GitLab