From de969a6325c12ae218e533727c4c4fec44378bd8 Mon Sep 17 00:00:00 2001
From: "Hubert Van de Walle (huvw)" <huvw@odoo.com>
Date: Tue, 21 Dec 2021 15:41:45 +0000
Subject: [PATCH] [FIX] sale_timesheet: Use invisible=1 on the
non_allow_billable field
Steps to follow
- Go to project
- Select a project task with timesheet
- Edit the view with studio
- Edit the timesheet list view
- Enable 'Show Invisible Elements'
- Select 'Non-Billable'
- Uncheck 'Invisible'
-> An exception is thrown
Cause of the issue
attrs.column_invisible was used with invisible
Solution
remove attrs.column_invisible
opw-2706370
closes odoo/odoo#81751
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>
---
addons/sale_timesheet/views/project_task_views.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/addons/sale_timesheet/views/project_task_views.xml b/addons/sale_timesheet/views/project_task_views.xml
index 7291b6122ee9..ed0c37a445ac 100644
--- a/addons/sale_timesheet/views/project_task_views.xml
+++ b/addons/sale_timesheet/views/project_task_views.xml
@@ -153,7 +153,7 @@
<field name="so_line" readonly="1" attrs="{'column_invisible': [('parent.allow_billable', '=', False)]}" context="{'with_remaining_hours': True}" optional="hide"/>
</xpath>
<xpath expr="//field[@name='timesheet_ids']/tree" position="inside">
- <field name="non_allow_billable" attrs="{'column_invisible': ['|', '&', '&', '|', ('parent.bill_type', '!=', 'customer_project'), ('parent.pricing_type', '!=', 'employee_rate'), ('parent.timesheet_product_id', '=', False), ('parent.sale_line_id', '=', False), '&', ('parent.bill_type', '=', 'customer_project'), ('parent.pricing_type', '=', 'employee_rate')]}" invisible="1"/>
+ <field name="non_allow_billable" invisible="1"/>
</xpath>
<xpath expr="//field[@name='remaining_hours']" position="after">
<field name="remaining_hours_available" invisible="1"/>
--
GitLab