From f29471ca73c20af219a239de7a543fc759ac5a88 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nshimiyimana=20S=C3=A9na?= <sesn@odoo.com>
Date: Tue, 9 May 2023 14:00:32 +0000
Subject: [PATCH] [FIX] hr_expense: use correct exchange rates on expense
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Bug
---
Let's say you make an expense in a foreign currency on date A. Then
you include this expense in an expense report. You set the report's
accounting date to B and post the journal entries. The system will
calculate the expense amounts based on the exchange rate on Date B.
But really, it should be using the exchange rate from Date A, the day
when the expense was made.
Steps to reproduce
------------------
* Enable multicurrency and make sure that you have different exchange
rates configured for two different dates, which we'll refer to as
Date A and Date B.
* Create an expense with a foreign currency and set the expense date to
Date A.
* Save and click `Create Report`
* Submit to manager, and approve the report
* Navigate to the 'Other Info' tab and set the report's accounting date
to Date B.
* Save and post the journal entries
Now, review the generated journal entries. You might notice that the
expense values have been calculated using the exchange rate from Date B,
rather than Date A.
opw-3119959
closes odoo/odoo#126922
X-original-commit: b6408e0da438f77fb69937df69c81c8392f797b3
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Séna Serge Nshimiyimana (sesn) <sesn@odoo.com>
---
addons/hr_expense/models/hr_expense.py | 2 +-
addons/hr_expense/tests/test_expenses.py | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/addons/hr_expense/models/hr_expense.py b/addons/hr_expense/models/hr_expense.py
index a08f85ea94f1..52c91b2f7d15 100644
--- a/addons/hr_expense/models/hr_expense.py
+++ b/addons/hr_expense/models/hr_expense.py
@@ -531,7 +531,7 @@ Or send your receipts at <a href="mailto:%(email)s?subject=Lunch%%20with%%20cust
move_line_name = expense.employee_id.name + ': ' + expense.name.split('\n')[0][:64]
account_src = expense._get_expense_account_source()
account_dst = expense._get_expense_account_destination()
- account_date = expense.sheet_id.accounting_date or expense.date or fields.Date.context_today(expense)
+ account_date = expense.date or expense.sheet_id.accounting_date or fields.Date.context_today(expense)
company_currency = expense.company_id.currency_id
diff --git a/addons/hr_expense/tests/test_expenses.py b/addons/hr_expense/tests/test_expenses.py
index 0a9d43bedb4f..556e3dd0304e 100644
--- a/addons/hr_expense/tests/test_expenses.py
+++ b/addons/hr_expense/tests/test_expenses.py
@@ -125,7 +125,7 @@ class TestExpenses(TestExpenseCommon):
# Receivable line (foreign currency):
{
'debit': 0.0,
- 'credit': 750,
+ 'credit': 500.0,
'amount_currency': -1500.0,
'account_id': self.company_data['default_account_payable'].id,
'product_id': False,
@@ -135,7 +135,7 @@ class TestExpenses(TestExpenseCommon):
},
# Tax line (foreign currency):
{
- 'debit': 97.83,
+ 'debit': 65.22,
'credit': 0.0,
'amount_currency': 195.652,
'account_id': self.company_data['default_account_tax_purchase'].id,
@@ -157,7 +157,7 @@ class TestExpenses(TestExpenseCommon):
},
# Product line (foreign currency):
{
- 'debit': 652.17,
+ 'debit': 434.78,
'credit': 0.0,
'amount_currency': 1304.348, # untaxed amount
'account_id': self.company_data['default_account_expense'].id,
@@ -188,7 +188,7 @@ class TestExpenses(TestExpenseCommon):
'currency_id': self.company_data['currency'].id,
},
{
- 'amount': -652.17,
+ 'amount': -434.78,
'date': fields.Date.from_string('2017-01-01'),
'account_id': self.analytic_account_2.id,
'currency_id': self.company_data['currency'].id,
--
GitLab