From f77d6d8b5d5db51ad0552fb27e3670b1489526a8 Mon Sep 17 00:00:00 2001
From: Nicolas Martinelli <nim@odoo.com>
Date: Tue, 21 Jan 2020 10:01:11 +0000
Subject: [PATCH] [FIX] repair: reserve parts
- Create some stock in WH/Stock for product A
- Create some stock in WH/Stock/Shelf 1 for product B
- Create a Repair Order for Product A in WH/Stock
- Add a line in Parts with B, leave the location to WH/Stock
- Process the order until the end
Negative quant is created in WH/Stock for B instead of using the
quantity in WH/Stock/Shelf 1.
We do a best effort in order to reserve the quantity in the
sub-locations.
opw-2177352
closes odoo/odoo#43716
X-original-commit: 2158f07cb2d32480f0db2a8e82aaea73ac266271
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
---
addons/repair/models/repair.py | 32 +++++++++++++++++++++-----------
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/addons/repair/models/repair.py b/addons/repair/models/repair.py
index ea338cf7cd25..cc5f60763786 100644
--- a/addons/repair/models/repair.py
+++ b/addons/repair/models/repair.py
@@ -506,21 +506,31 @@ class Repair(models.Model):
'partner_id': repair.address_id.id,
'location_id': operation.location_id.id,
'location_dest_id': operation.location_dest_id.id,
- 'move_line_ids': [(0, 0, {'product_id': operation.product_id.id,
- 'lot_id': operation.lot_id.id,
- 'product_uom_qty': 0, # bypass reservation here
- 'product_uom_id': operation.product_uom.id,
- 'qty_done': operation.product_uom_qty,
- 'package_id': False,
- 'result_package_id': False,
- 'owner_id': owner_id,
- 'location_id': operation.location_id.id, #TODO: owner stuff
- 'company_id': repair.company_id.id,
- 'location_dest_id': operation.location_dest_id.id,})],
'repair_id': repair.id,
'origin': repair.name,
'company_id': repair.company_id.id,
})
+
+ # Best effort to reserve the product in a (sub)-location where it is available
+ product_qty = move.product_uom._compute_quantity(
+ operation.product_uom_qty, move.product_id.uom_id, rounding_method='HALF-UP')
+ available_quantity = self.env['stock.quant']._get_available_quantity(
+ move.product_id,
+ move.location_id,
+ lot_id=operation.lot_id.id,
+ strict=False,
+ )
+ move._update_reserved_quantity(
+ product_qty,
+ available_quantity,
+ move.location_id,
+ lot_id=operation.lot_id.id,
+ strict=False,
+ )
+ # Then, set the quantity done. If the required quantity was not reserved, negative
+ # quant is created in operation.location_id.
+ move._set_quantity_done(operation.product_uom_qty)
+
moves |= move
operation.write({'move_id': move.id, 'state': 'done'})
move = Move.create({
--
GitLab