Skip to content
Snippets Groups Projects

Avoid closing dialogs when cicking outside. Closing button better placement.

Merged Dani Quilez requested to merge feature/close-button-dialog into release/1.0.10
1 unresolved thread

This tries to fix a issue reported by Partago relating people using the forms and closing it accidentally.

TMF ticket TS22349

Edited by Enrico Stano

Merge request reports

Pipeline #15075 passed

Pipeline passed for be5af930 on feature/close-button-dialog

Approved by

Merged by Dani QuilezDani Quilez 2 years ago (Oct 20, 2022 9:14am UTC)

Merge details

  • Changes merged into release/1.0.10 with 9d4241c5.
  • Deleted the source branch.

Pipeline #15082 passed

Pipeline passed for 9d4241c5 on release/1.0.10

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
72 72 as='div'
73 73 className='fixed z-50 inset-0 overflow-y-auto'
74 74 initialFocus={initialFocusRef}
75 onClose={onClose}
75 onClose={() => {
  • Gil Gasso approved this merge request

    approved this merge request

  • Enrico Stano approved this merge request

    approved this merge request

  • Enrico Stano changed the description

    changed the description

  • closed

  • reopened

  • Dani Quilez restored source branch feature/close-button-dialog

    restored source branch feature/close-button-dialog

  • Dani Quilez changed target branch from main to release/1.0.10

    changed target branch from main to release/1.0.10

  • Dani Quilez mentioned in commit 9d4241c5

    mentioned in commit 9d4241c5

  • merged

  • Please register or sign in to reply
    Loading