Skip to content
Snippets Groups Projects

FIX: subscriptions use vat instead email

Merged FIX: subscriptions use vat instead email
FIX_subscriptions_use_vat_instead_email into 14_energy_communities
1 unresolved thread
Merged Daniil Digtyar Vasilieva requested to merge FIX_subscriptions_use_vat_instead_email into 14_energy_communities
1 unresolved thread

FIX Issue #26 (closed)

https://trello.com/c/LGRZ3Bli/159-use-vat-to-identify-existing-respartner-instead-of-email

Change list:

  • Inherit method of cooperator to search by vat instead of email.
  • Added method to partner to search by vat.
  • Added VAT field required and states to fix control in form view.

TODO

  • company_register_number is a field used by cooperator for cooperators companies, we should use vat for companies and persons.
  • Create a PR to l10n_es_cooperator, we're still waiting OCA to resolve the PR

Merge request reports

Pipeline #22340 passed

Stage: test

Pipeline passed for edffac61 on FIX_subscriptions_use_vat_instead_email

Approved by
Daniil Digtyar Vasilieva Xavier Bonet Enrico Stano

Merged by Xavier BonetXavier Bonet 2 years ago (Mar 3, 2023 11:40am UTC)

Merge details

  • Changes merged into 14_energy_communities with 96d7ebf8.
  • Deleted the source branch.

Pipeline #22524 passed

Stage: test

Pipeline passed for 96d7ebf8 on 14_energy_communities

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
energy_communities/models/subscription_request.py
43 45 vals = super(SubscriptionRequest, self).get_partner_vals()
44 46 vals["company_id"] = self.company_id.id
45 47 return vals
48
49 def _find_partner_from_create_vals(self, vals):
50 partner_model = self.env["res.partner"]
51 partner_id = vals.get("partner_id")
52 if partner_id:
53 return partner_model.browse(partner_id)
54 if vals.get("is_company"):
55 partner = partner_model.get_cooperator_from_crn(
56 vals.get("company_register_number")
57 )
  • Enrico Stano approved this merge request

    approved this merge request

  • Daniil Digtyar Vasilieva approved this merge request

    approved this merge request

  • Xavier Bonet approved this merge request

    approved this merge request

  • Xavier Bonet mentioned in commit 96d7ebf8

    mentioned in commit 96d7ebf8

  • Xavier Bonet merged

    merged

  • Enrico Stano unassigned @DaniilDigtyar

    unassigned @DaniilDigtyar

    • Please register or sign in to reply