Skip to content
Snippets Groups Projects
  • Romain Derie's avatar
    17a182fb
    [FIX] website: repair (again) the nightly website standalone test · 17a182fb
    Romain Derie authored
    Commit [1] actually "repair" the test theme installation that was
    actually not calling `_post_copy()` for the website/themes created
    through the `_post_init` hook of the `test_themes` module.
    By doing so, the Nano theme now correctly activated the
    `footer_language_selector` view, meaning that the tour would fail as
    this Nano view would mess up with the tour (that Nano view was returned
    on top of the Theme custo view).
    
    Those website standalone tests should really be part of the regular
    testing suite and not in the nightly build only:
    1. This is getting really annoying to fix it again and again, we
       wouldn't have to do that if it was in the regular testing base as it
       could not be broken. This is a waste of time for no reason, as we
       need to investigate, understand and find a fix.
    2. For now it only broke due to no real bug, most of the time it is
       because the test need to be adapted to a theme change or something,
       but one day someone will be able to break the website core mechanisms
       (COW, theme install etc) and this will be problematic.
       Note that if this was to happen, the runbot team will be handling the
       issue and the fix with the people that broke it, as it was promised
       when we discussed about moving those tests in the regular testing
       suite. It was the conscensus for us to accept to leave those tests in
       the nightly only (we didn't really had a choice tho).
    
    [1]: https://github.com/odoo/design-themes/commit/fea847977d8bd4b0c0ddfc7685e3d3dc0933759c
    
    
    
    closes odoo/odoo#106026
    
    Signed-off-by: default avatarRomain Derie (rde) <rde@odoo.com>
    17a182fb
    History
    [FIX] website: repair (again) the nightly website standalone test
    Romain Derie authored
    Commit [1] actually "repair" the test theme installation that was
    actually not calling `_post_copy()` for the website/themes created
    through the `_post_init` hook of the `test_themes` module.
    By doing so, the Nano theme now correctly activated the
    `footer_language_selector` view, meaning that the tour would fail as
    this Nano view would mess up with the tour (that Nano view was returned
    on top of the Theme custo view).
    
    Those website standalone tests should really be part of the regular
    testing suite and not in the nightly build only:
    1. This is getting really annoying to fix it again and again, we
       wouldn't have to do that if it was in the regular testing base as it
       could not be broken. This is a waste of time for no reason, as we
       need to investigate, understand and find a fix.
    2. For now it only broke due to no real bug, most of the time it is
       because the test need to be adapted to a theme change or something,
       but one day someone will be able to break the website core mechanisms
       (COW, theme install etc) and this will be problematic.
       Note that if this was to happen, the runbot team will be handling the
       issue and the fix with the people that broke it, as it was promised
       when we discussed about moving those tests in the regular testing
       suite. It was the conscensus for us to accept to leave those tests in
       the nightly only (we didn't really had a choice tho).
    
    [1]: https://github.com/odoo/design-themes/commit/fea847977d8bd4b0c0ddfc7685e3d3dc0933759c
    
    
    
    closes odoo/odoo#106026
    
    Signed-off-by: default avatarRomain Derie (rde) <rde@odoo.com>
test_views_inherit_module_update.py 4.58 KiB