Skip to content
Snippets Groups Projects
  • Adrien Widart's avatar
    95ba17ae
    [FIX] website_sale_digital: ignore Note/Section · 95ba17ae
    Adrien Widart authored
    
    When downloading the digital file, if there exists one SO linked to the
    current customer and that contains a Note/Section, the web page will be
    redirected to the "Internal Server Error" web page.
    
    To reproduce the error:
    (Need sale_management)
    1. Create a customer C
    2. Grant C portal access
    3. Create a product P
        - Add a digital attachment
    4. Create a SO
        - Customer: C
        - Add product P
        - Add a note
    5. Save, Confirm, Create Invoice, Register Payment
    6. Sign in with P
    7. Consult the SO web page
    8. Download the file attached to the SO line
    
    Error: The page is redirected to the "Internal Server Error" web page.
    
    When downloading the document, the module checks the customer's access.
    To do so, it gets all relevant invoices and free products. Here is the
    problem, when getting the free products, the domain includes the SO
    lines used for Section and Note. As a result, when it tries to read the
    product of such a line, this will raise an error.
    
    OPW-2419478
    
    closes odoo/odoo#66904
    
    Signed-off-by: default avatarAdrien Widart <adwid@users.noreply.github.com>
    95ba17ae
    History
    [FIX] website_sale_digital: ignore Note/Section
    Adrien Widart authored
    
    When downloading the digital file, if there exists one SO linked to the
    current customer and that contains a Note/Section, the web page will be
    redirected to the "Internal Server Error" web page.
    
    To reproduce the error:
    (Need sale_management)
    1. Create a customer C
    2. Grant C portal access
    3. Create a product P
        - Add a digital attachment
    4. Create a SO
        - Customer: C
        - Add product P
        - Add a note
    5. Save, Confirm, Create Invoice, Register Payment
    6. Sign in with P
    7. Consult the SO web page
    8. Download the file attached to the SO line
    
    Error: The page is redirected to the "Internal Server Error" web page.
    
    When downloading the document, the module checks the customer's access.
    To do so, it gets all relevant invoices and free products. Here is the
    problem, when getting the free products, the domain includes the SO
    lines used for Section and Note. As a result, when it tries to read the
    product of such a line, this will raise an error.
    
    OPW-2419478
    
    closes odoo/odoo#66904
    
    Signed-off-by: default avatarAdrien Widart <adwid@users.noreply.github.com>