-
- Downloads
[REF] survey: on survey.{question,user_input.line}, make type and field names match
PURPOSE As new features are about to land in survey, notably live interactions [1] and new survey building [2] performing a pre cleaning is necessary. In this PR we clean survey models by: removing unnecessary fields, cleaning some code and finally renaming models. SPECIFICATIONS To better understand question type and their input type, we update some of ``survey.question`` ``question_type`` keys : Type----Old type-----New type text----free_text----text_box char----textbox------char_box Untouched question types: ``numerical_box``, ``date``, ``datetime``, ``simple_choice``, ``multiple_choice``, ``matrix``. Those are already understandable. Then ``survey.user_input.line`` ``answer_type`` keys are also updated to match their question type counterparts QuestType--------Old type-----New type text_box---------free_text----text_box char_box---------text---------char_box numerical_box----number-------numerical_box Then ``survey.user_input.line`` fields used to store the value are updated to propagate the new naming AnswerLineType----Old field----------New field text_box----------value_free_text----value_text_box char_box----------value_text---------value_char_box numerical_box-----value_number-------value_numerical_box Untouched answer types and field storing value: ``date``, ``datetime`` still refer to same question type and use value_date / value_datetime fields. ``simple_choice``, ``multiple_choice`` and ``matrix`` still use ``suggestion`` answer type and ``suggested_answer_id`` (+ ``matrix_row_id``) to store link to ``survey.question.answer`` records. LINKS [0] Related to Task ID 2061901 (survey models cleaning and preparation) [1] Task ID 1972640 (live interactions) [2] Task ID 2119587 (new frontend for building surveys) PR #40765
Showing
- addons/hr_recruitment_survey/data/survey_demo.xml 7 additions, 7 deletionsaddons/hr_recruitment_survey/data/survey_demo.xml
- addons/survey/data/survey.user_input.line.csv 11 additions, 11 deletionsaddons/survey/data/survey.user_input.line.csv
- addons/survey/data/survey_demo_certification.xml 1 addition, 1 deletionaddons/survey/data/survey_demo_certification.xml
- addons/survey/data/survey_demo_feedback.xml 2 additions, 2 deletionsaddons/survey/data/survey_demo_feedback.xml
- addons/survey/models/survey_question.py 6 additions, 6 deletionsaddons/survey/models/survey_question.py
- addons/survey/models/survey_survey.py 5 additions, 5 deletionsaddons/survey/models/survey_survey.py
- addons/survey/models/survey_user.py 13 additions, 17 deletionsaddons/survey/models/survey_user.py
- addons/survey/static/src/js/survey_form.js 2 additions, 2 deletionsaddons/survey/static/src/js/survey_form.js
- addons/survey/tests/common.py 4 additions, 4 deletionsaddons/survey/tests/common.py
- addons/survey/tests/test_certification_flow.py 3 additions, 3 deletionsaddons/survey/tests/test_certification_flow.py
- addons/survey/tests/test_survey.py 4 additions, 4 deletionsaddons/survey/tests/test_survey.py
- addons/survey/tests/test_survey_compute_pages_questions.py 9 additions, 9 deletionsaddons/survey/tests/test_survey_compute_pages_questions.py
- addons/survey/tests/test_survey_flow.py 1 addition, 1 deletionaddons/survey/tests/test_survey_flow.py
- addons/survey/tests/test_survey_invite.py 1 addition, 1 deletionaddons/survey/tests/test_survey_invite.py
- addons/survey/tests/test_survey_security.py 14 additions, 14 deletionsaddons/survey/tests/test_survey_security.py
- addons/survey/tests/test_survey_ui_certification.py 1 addition, 1 deletionaddons/survey/tests/test_survey_ui_certification.py
- addons/survey/tests/test_survey_ui_feedback.py 2 additions, 2 deletionsaddons/survey/tests/test_survey_ui_feedback.py
- addons/survey/views/survey_question_views.xml 8 additions, 8 deletionsaddons/survey/views/survey_question_views.xml
- addons/survey/views/survey_templates.xml 20 additions, 20 deletionsaddons/survey/views/survey_templates.xml
- addons/survey/views/survey_templates_statistics.xml 8 additions, 8 deletionsaddons/survey/views/survey_templates_statistics.xml
Loading
Please register or sign in to comment