[FIX] mail: no crash when uploading attachment on draft record

Before this commit, when uploading an attachment on a draft record,
there was the following crash.

This happens because the file uploader in use was the one from when
the record was in draft. The file uploader is changed when the
record is no longer in draft, so the new file uploader should be used
instead.

This commit fixes the issue by delaying slightly saving of record in
chatter model, so that we are sure the chatter record is no longer
temporary (= record not longer in draft), which in consequence create
a new file uploader that actually works.

opw-3280676

closes odoo/odoo#119515

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

addons/mail/static/src/models/chatter.js

@@ -64,6 +64,8 @@ registerModel({
                 createNewRecordDeferred: composerData ? makeDeferred() : null,
             });
             await this.createNewRecordDeferred;
+            // Give some time to chatter model being updated by save.
+            await new Promise((resolve) => setTimeout(() => requestAnimationFrame(resolve)));
             return saved;
         },
         onAttachmentsLoadingTimeout() {
@@ -282,14 +284,9 @@ registerModel({
                 });
                 this.createNewRecordDeferred.resolve();
             }
-            if (this.createNewRecordFiles) {
-                const files = this.createNewRecordFiles;
-                this.fileUploader.uploadFiles(files);
-            }
             this.update({
                 createNewRecordComposerData: clear(),
                 createNewRecordDeferred: clear(),
-                createNewRecordFiles: clear(),
             });
         },
         /**
@@ -538,7 +535,6 @@ registerModel({
         webRecord: attr(),
         createNewRecordComposerData: attr(),
         createNewRecordDeferred: attr(),
-        createNewRecordFiles: attr(),
     },
     onChanges: [
         {

addons/mail/static/src/models/drop_zone_view.js

@@ -71,8 +71,6 @@ registerModel({
                         if (!saved) {
                             return;
                         }
-                        chatter.update({ createNewRecordFiles: files });
-                        return;
                     }
                     await chatter.fileUploader.uploadFiles(files);
                     return;