-
- Downloads
[IMP] web: use a classname to show/hide widgets
The problem of $el.show()/hide() is that calling show() on a jQuery element on which there is no display rule in the stylesheet automatically sets 'display: block'. However, when a jQuery element is not yet in the DOM, the rules defined on it are not yet applied, meaning that calling show() will set its display to block (in inline style), even if there is different a css rule (e.g. 'dislay: flex'). As the inline style takes the priority over the stylesheet, the correct display won't be applied, even when the widget will be appended in the DOM, resulting in a possibly broken layout.
Showing
- addons/web/static/src/css/base.css 5 additions, 8 deletionsaddons/web/static/src/css/base.css
- addons/web/static/src/css/base.sass 3 additions, 0 deletionsaddons/web/static/src/css/base.sass
- addons/web/static/src/js/action_manager.js 1 addition, 1 deletionaddons/web/static/src/js/action_manager.js
- addons/web/static/src/js/framework/widget.js 2 additions, 2 deletionsaddons/web/static/src/js/framework/widget.js
- addons/web/static/src/js/views/form_common.js 2 additions, 2 deletionsaddons/web/static/src/js/views/form_common.js
- addons/web/static/src/js/views/form_view.js 2 additions, 1 deletionaddons/web/static/src/js/views/form_view.js
- addons/web/static/src/js/views/graph_view.js 0 additions, 2 deletionsaddons/web/static/src/js/views/graph_view.js
- addons/web/static/src/js/views/pivot_view.js 0 additions, 1 deletionaddons/web/static/src/js/views/pivot_view.js
- addons/web/static/src/js/views/search_view.js 1 addition, 1 deletionaddons/web/static/src/js/views/search_view.js
- addons/web/static/src/js/views/tree_view.js 0 additions, 6 deletionsaddons/web/static/src/js/views/tree_view.js
- addons/web/static/src/js/widgets/pager.js 2 additions, 2 deletionsaddons/web/static/src/js/widgets/pager.js
Loading
Please register or sign in to comment