[FIX] website_form: remove evaluated domains

- Install helpdesk_stock
- Publish the team Customer Care on the website
- Edit the ticket submission form
- Add the field 'Lot/Serial Number'

A crash occurs because of a malformed domain.

It happens because the domain is a string, and therefore should be
evaluated.

We remove the string domains since it won't be possible to evaluated
them in the website form anyway.

opw-2176144

closes odoo/odoo#43427

X-original-commit: abc85e17
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

addons/website_form/models/models.py

@@ -58,8 +58,12 @@ class website_form_model(models.Model):
             fields_get[field]['required'] = False
 
         # Remove readonly and magic fields
+        # Remove string domains which are supposed to be evaluated
+        # (e.g. "[('product_id', '=', product_id)]")
         MAGIC_FIELDS = models.MAGIC_COLUMNS + [model.CONCURRENCY_CHECK_FIELD]
         for field in list(fields_get):
+            if 'domain' in fields_get[field] and isinstance(fields_get[field]['domain'], str):
+                del fields_get[field]['domain']
             if fields_get[field]['readonly'] or field in MAGIC_FIELDS:
                 del fields_get[field]