-
- Downloads
[IMP] web_editor, *: change height/margin system to padding system
* web, website, mass_mailing Before this commit, the editor allowed defining the margin of some elements and the height of some elements. There were three main problems with this system: 1) When an user dragged the arrow, he often expected to change the size of the element while he was in fact changing the margin 2) When changing the margin, you increase the space between two elements but with a white space (while most users want a space with the same color of the block they are resizing = padding) 3) When changing the height, the user was able to hide snippet parts and the height was not consistent accross screen sizes Now, the only thing you can edit is padding. There is only one arrow for each direction, which allows increasing spacing and consistent dimension at the same time. The only feature that is lost with this change is the ability to control vertical alignement of colored columns. This is not a problem as colored columns are rare in our current snippets and there still have the possibility to add margin classes by hand if necessary (there are also plans to control vertical alignement another way). Note: margin classes are kept for compatibility.
Showing
- addons/mass_mailing/static/src/js/mass_mailing_editor.js 21 additions, 17 deletionsaddons/mass_mailing/static/src/js/mass_mailing_editor.js
- addons/mass_mailing/static/src/less/themes/theme_default.less 7 additions, 27 deletions...ns/mass_mailing/static/src/less/themes/theme_default.less
- addons/mass_mailing/views/snippets_themes_options.xml 4 additions, 10 deletionsaddons/mass_mailing/views/snippets_themes_options.xml
- addons/web/static/src/js/widgets/switch_company_menu.js 1 addition, 1 deletionaddons/web/static/src/js/widgets/switch_company_menu.js
- addons/web_editor/static/src/js/editor/snippets.editor.js 3 additions, 4 deletionsaddons/web_editor/static/src/js/editor/snippets.editor.js
- addons/web_editor/static/src/js/editor/snippets.options.js 138 additions, 202 deletionsaddons/web_editor/static/src/js/editor/snippets.options.js
- addons/web_editor/static/src/less/web_editor.common.less 61 additions, 43 deletionsaddons/web_editor/static/src/less/web_editor.common.less
- addons/web_editor/static/src/less/web_editor.ui.less 59 additions, 160 deletionsaddons/web_editor/static/src/less/web_editor.ui.less
- addons/web_editor/static/src/xml/snippets.xml 5 additions, 9 deletionsaddons/web_editor/static/src/xml/snippets.xml
- addons/website/static/src/js/content/snippets.animation.js 20 additions, 0 deletionsaddons/website/static/src/js/content/snippets.animation.js
- addons/website/static/src/js/editor/snippets.options.js 19 additions, 16 deletionsaddons/website/static/src/js/editor/snippets.options.js
- addons/website/static/src/less/website.snippets.less 0 additions, 3 deletionsaddons/website/static/src/less/website.snippets.less
- addons/website/views/snippets.xml 48 additions, 50 deletionsaddons/website/views/snippets.xml
Loading
Please register or sign in to comment