-
- Downloads
[FIX] point_of_sale,pos_restaurant: remove step_delay in pos test tours
Tours with `step_delay` potentially hide errors because of missing tour steps.
This is mainly caused by unfinished renders within the `step_delay` between
two steps. It is possible that the render after the 1st trigger is not yet
finished but the 2nd step trigger already existed in the screen. Because the
render result of 1st step is late and the 2nd step is already triggered, the
3rd step will fail. Note that the 3rd step will occassionally fail because
render of the 1st step is most of the time faster than step_delay but
there is no guarantee that the render is always faster because of occassional
cpu slow downs.
Runbot will eventually catch these tour errors which it did with the ticket
screen tour.
In this commit, we removed the `step_delay` in the pos tours. We also
supplemented the missing step in the ticket screen tour which was the cause
of random runbot error when there was `step_delay`.
We also figured that value property of input element is not observed by the
tour service's mutation observer, which result to an indeterministic error
in a step in tip screen. To fix this, we introduce an attribute to the input
element which is used in the step trigger.
closes odoo/odoo#56949
Signed-off-by:
pimodoo <pimodoo@users.noreply.github.com>
Showing
- addons/point_of_sale/tests/test_frontend.py 4 additions, 4 deletionsaddons/point_of_sale/tests/test_frontend.py
- addons/pos_restaurant/static/src/xml/Screens/TipScreen.xml 1 addition, 1 deletionaddons/pos_restaurant/static/src/xml/Screens/TipScreen.xml
- addons/pos_restaurant/static/tests/tours/TicketScreen.tour.js 2 additions, 0 deletions...ns/pos_restaurant/static/tests/tours/TicketScreen.tour.js
- addons/pos_restaurant/static/tests/tours/helpers/TipScreenTourMethods.js 2 additions, 6 deletions...aurant/static/tests/tours/helpers/TipScreenTourMethods.js
- addons/pos_restaurant/tests/test_frontend.py 3 additions, 3 deletionsaddons/pos_restaurant/tests/test_frontend.py
Loading
Please register or sign in to comment