Skip to content
Snippets Groups Projects
Commit 40290102 authored by mega-odoo's avatar mega-odoo
Browse files

[FIX] web_editor: prevent error when edit the float, monetary section in website


'replace() argument 1 must be str, not bool' is generated if the user edit a
float or monetary section in the website view.

Steps to Reproduce

- Make debugger mode ON.
- Go to Settings > Translations > Languages.
- Remove the value of the 'Thousands Separator' field from the current user
language.
- Install the 'eCommerce' module.
- Go to the website.
- Go to the shop menu, and click any product from the product list.
- Click on the Edit button and try to edit any float or
monetary section like a product price (eg. change a product price from 750 to
70) and click on the Save button.

And traceback will be generated.

Applying this commit will resolve this issue.

sentry-4148693017

closes odoo/odoo#125634

X-original-commit: b895175c
Signed-off-by: default avatarDavid Monjoie (dmo) <dmo@odoo.com>
parent 2899888a
No related branches found
No related tags found
No related merge requests found
......@@ -175,7 +175,7 @@ class Integer(models.AbstractModel):
def from_html(self, model, field, element):
lang = self.user_lang()
value = element.text_content().strip()
return int(value.replace(lang.thousands_sep, ''))
return int(value.replace(lang.thousands_sep or '', ''))
class Float(models.AbstractModel):
......@@ -187,7 +187,7 @@ class Float(models.AbstractModel):
def from_html(self, model, field, element):
lang = self.user_lang()
value = element.text_content().strip()
return float(value.replace(lang.thousands_sep, '')
return float(value.replace(lang.thousands_sep or '', '')
.replace(lang.decimal_point, '.'))
......@@ -494,7 +494,7 @@ class Monetary(models.AbstractModel):
value = element.find('span').text.strip()
return float(value.replace(lang.thousands_sep, '')
return float(value.replace(lang.thousands_sep or '', '')
.replace(lang.decimal_point, '.'))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment