Skip to content
Snippets Groups Projects
Commit 46784659 authored by Olivier Dony's avatar Olivier Dony
Browse files

[IMP] ir.attachment: include traceback when logging low-level filesystem errors

parent bce4e227
Branches
Tags
No related merge requests found
......@@ -123,7 +123,7 @@ class ir_attachment(osv.osv):
else:
r = open(full_path,'rb').read().encode('base64')
except IOError:
_logger.error("_read_file reading %s",full_path)
_logger.exception("_read_file reading %s", full_path)
return r
def _file_write(self, cr, uid, value):
......@@ -134,7 +134,7 @@ class ir_attachment(osv.osv):
with open(full_path, 'wb') as fp:
fp.write(bin_value)
except IOError:
_logger.error("_file_write writing %s", full_path)
_logger.exception("_file_write writing %s", full_path)
return fname
def _file_delete(self, cr, uid, fname):
......@@ -144,10 +144,10 @@ class ir_attachment(osv.osv):
try:
os.unlink(full_path)
except OSError:
_logger.error("_file_delete could not unlink %s",full_path)
_logger.exception("_file_delete could not unlink %s", full_path)
except IOError:
# Harmless and needed for race conditions
_logger.error("_file_delete could not unlink %s",full_path)
_logger.exception("_file_delete could not unlink %s", full_path)
def _data_get(self, cr, uid, ids, name, arg, context=None):
if context is None:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment