[IMP] stock: Improve usability for product scraping

- Made 'Picking_id' invisible
- Removed create & edit options for locations
- scrap_location_id becomes required

addons/stock/models/stock_scrap.py

@@ -41,7 +41,7 @@ class StockScrap(models.Model):
         required=True, states={'done': [('readonly', True)]}, default=_get_default_location_id)
     scrap_location_id = fields.Many2one(
         'stock.location', 'Scrap Location', default=_get_default_scrap_location_id,
-        domain="[('scrap_location', '=', True)]", states={'done': [('readonly', True)]})
+        domain="[('scrap_location', '=', True)]", required=True, states={'done': [('readonly', True)]})
     scrap_qty = fields.Float('Quantity', default=1.0, required=True, states={'done': [('readonly', True)]})
     state = fields.Selection([
         ('draft', 'Draft'),

addons/stock/views/stock_scrap_views.xml

@@ -115,13 +115,13 @@
                             </div>
                         </group>
                         <group>
-                            <field name="picking_id" attrs="{'invisible': [('picking_id', '=', False)]}"/>
+                            <field name="picking_id" invisible="1"/>
                             <field name="tracking" invisible="1"/>
                             <field name="lot_id" attrs="{'invisible': [('tracking', '=', 'none')]}" groups="stock.group_production_lot"/>
                             <field name="package_id" groups="stock.group_tracking_lot"/>
                             <field name="owner_id" groups="stock.group_tracking_owner"/>
-                            <field name="location_id" groups="stock.group_stock_multi_locations"/>
-                            <field name="scrap_location_id" groups="stock.group_stock_multi_locations"/>
+                            <field name="location_id" groups="stock.group_stock_multi_locations" options="{'no_open': True, 'no_create': True}"/>
+                            <field name="scrap_location_id" groups="stock.group_stock_multi_locations" options="{'no_open': True, 'no_create': True}" />
                         </group>
                     </group>
                     <footer>