[FIX] board: prevent add to dashboard with no actionID

Steps to reproduce:
- Go to Purchase -> Reporting -> Dashboard
- click on the "expand" arrows of the pivot view
- favorites - add to dashboard

Bug:
adding a view with no actionID causes the dashboard to crash on load
this [commit] prevents adding a view with no actionID

Fix:
added a default value of False to add_to_dashboard actionId
only display the option to add_to_dashboard for views that have actionId

opw-2965036

[commit]:https://github.com/odoo-dev/odoo/commit/7180d948f084d4f68d1660cb884c95aaf41288fa



closes odoo/odoo#100043

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

addons/board/static/src/add_to_board/add_to_board.js

@@ -44,7 +44,7 @@ export class AddToBoard extends Component {
         };
 
         const result = await this.rpc("/board/add_to_dashboard", {
-            action_id: this.env.config.actionId,
+            action_id: this.env.config.actionId || false,
             context_to_save: contextToSave,
             domain,
             name: this.state.name,
@@ -84,10 +84,10 @@ export class AddToBoard extends Component {
 
 AddToBoard.template = "board.AddToBoard";
 
-const addToBoardItem = {
+export const addToBoardItem = {
     Component: AddToBoard,
     groupNumber: 4,
-    isDisplayed: ({ config }) => config.actionType === "ir.actions.act_window",
+    isDisplayed: ({ config }) => config.actionType === "ir.actions.act_window" && config.actionId,
 };
 
 favoriteMenuRegistry.add("add-to-board", addToBoardItem, { sequence: 10 });

addons/board/static/tests/dashboard_tests.js

@@ -27,7 +27,7 @@ odoo.define("board.dashboard_tests", function (require) {
     const { mouseEnter, triggerEvent } = require("@web/../tests/helpers/utils");
     const LegacyFavoriteMenu = require("web.FavoriteMenu");
     const LegacyAddToBoard = require("board.AddToBoardMenu");
-    const { AddToBoard } = require("@board/add_to_board/add_to_board");
+    const { addToBoardItem } = require("@board/add_to_board/add_to_board");
 
     const { createWebClient, doAction } = require("@web/../tests/webclient/helpers");
     var createView = testUtils.createView;
@@ -85,11 +85,7 @@ odoo.define("board.dashboard_tests", function (require) {
             LegacyFavoriteMenu.registry.add("add-to-board-menu", LegacyAddToBoard, 10);
             favoriteMenuRegistry.add(
                 "add-to-board",
-                {
-                    Component: AddToBoard,
-                    groupNumber: 4,
-                    isDisplayed: ({ config }) => config.actionType === "ir.actions.act_window",
-                },
+                addToBoardItem,
                 { sequence: 10 }
             );
             serverData = { models: this.data };
@@ -906,6 +902,36 @@ odoo.define("board.dashboard_tests", function (require) {
         testUtils.mock.unpatch(ListController);
     });
 
+    QUnit.test("add to dashboard with no action id", async function (assert) {
+        assert.expect(2);
+
+        serverData.views = {
+            "partner,false,pivot": '<pivot><field name="foo"/></pivot>',
+            "partner,false,search": '<search/>',
+        };
+        registry.category("services").add("user", makeFakeUserService());
+        const webClient = await createWebClient({ serverData });
+
+        await doAction(webClient, {
+            id: false,
+            res_model: "partner",
+            type: "ir.actions.act_window",
+            views: [[false, "pivot"]],
+        });
+        await toggleFavoriteMenu(webClient.el);
+        assert.containsNone(webClient, ".o_add_to_board");
+
+        // Sanity check
+        await doAction(webClient, {
+            id: 1,
+            res_model: "partner",
+            type: "ir.actions.act_window",
+            views: [[false, "pivot"]],
+        });
+        await toggleFavoriteMenu(webClient.el);
+        assert.containsOnce(webClient, ".o_add_to_board");
+    });
+
     QUnit.test("save two searches to dashboard", async function (assert) {
         // the second search saved should not be influenced by the first
         assert.expect(2);
@@ -1287,7 +1313,7 @@ odoo.define("board.dashboard_tests", function (require) {
 
         const mockRPC = (route) => {
             if (route === "/board/add_to_dashboard") {
-                assert.step("add to board")
+                assert.step("add to board");
                 return Promise.resolve(true);
             }
         };