-
- Downloads
[IMP] bus: re-factoring of bus.bus (Longpolling and CrossTab)
The purpose of this change is to make the code clearer and testable. In this change, the 'tab_manager' static object was merged with the bus cross tab. Cleaning was done to clearly define private and public functions as well as handlers. The methods are documented and the constants are now defined on the class. The bus use the service behavior with 'trigger_up'. 'bus.CrossTab' who extend 'bus.Longpolling' are instantiated by the bus service. The class is always instantiated with a parent, or root in the case of the website (im_livechat), to use the ajax and localstorage services. So the behavior, perhaps logger or redefined by the parents.
Showing
- addons/bus/static/src/js/bus.js 0 additions, 485 deletionsaddons/bus/static/src/js/bus.js
- addons/bus/static/src/js/crosstab_bus.js 355 additions, 0 deletionsaddons/bus/static/src/js/crosstab_bus.js
- addons/bus/static/src/js/longpolling_bus.js 255 additions, 0 deletionsaddons/bus/static/src/js/longpolling_bus.js
- addons/bus/static/src/js/services/bus_service.js 23 additions, 21 deletionsaddons/bus/static/src/js/services/bus_service.js
- addons/bus/static/tests/bus_tests.js 163 additions, 0 deletionsaddons/bus/static/tests/bus_tests.js
- addons/bus/views/bus.xml 13 additions, 8 deletionsaddons/bus/views/bus.xml
- addons/calendar/static/src/js/base_calendar.js 1 addition, 1 deletionaddons/calendar/static/src/js/base_calendar.js
- addons/im_livechat/static/src/js/im_livechat.js 4 additions, 5 deletionsaddons/im_livechat/static/src/js/im_livechat.js
- addons/im_livechat/views/im_livechat_channel_templates.xml 8 additions, 3 deletionsaddons/im_livechat/views/im_livechat_channel_templates.xml
- addons/im_support/static/src/js/mail_manager.js 8 additions, 5 deletionsaddons/im_support/static/src/js/mail_manager.js
- addons/im_support/static/src/js/support_bus.js 12 additions, 14 deletionsaddons/im_support/static/src/js/support_bus.js
- addons/im_support/static/tests/helpers/test_utils.js 9 additions, 0 deletionsaddons/im_support/static/tests/helpers/test_utils.js
- addons/im_support/static/tests/systray_tests.js 2 additions, 2 deletionsaddons/im_support/static/tests/systray_tests.js
- addons/im_support/views/assets.xml 7 additions, 1 deletionaddons/im_support/views/assets.xml
- addons/mail/static/src/js/services/mail_document_thread_manager.js 7 additions, 10 deletions...il/static/src/js/services/mail_document_thread_manager.js
- addons/mail/static/src/js/services/mail_manager.js 5 additions, 6 deletionsaddons/mail/static/src/js/services/mail_manager.js
- addons/mail/static/src/js/services/mail_notification_manager.js 1 addition, 1 deletion.../mail/static/src/js/services/mail_notification_manager.js
- addons/mail/static/tests/chatter_tests.js 2 additions, 5 deletionsaddons/mail/static/tests/chatter_tests.js
- addons/mail/static/tests/discuss_moderation_tests.js 5 additions, 9 deletionsaddons/mail/static/tests/discuss_moderation_tests.js
- addons/mail/static/tests/discuss_tests.js 12 additions, 6 deletionsaddons/mail/static/tests/discuss_tests.js
Loading
Please register or sign in to comment