Skip to content
Snippets Groups Projects
Commit 716ff76d authored by Julien Castiaux's avatar Julien Castiaux
Browse files

[FIX] sale: force maximum section/subtotal width


Step to reproduce:
- Install sale (sale_management) and studio (web_studio)
- Change the document template (settings > configuration > general
settings) to select the second one
- Go to an order form
- Enable studio, select "Reports" in the right tab
- Edit the "Quotation/Order" report, add a new colomn
- Back to the order form, enable dev mode and add a section to the order
lines.
- Print the report => the section is not using all the available place.

The section/subtotal are using a colspan to use all the place in the
table, this colspan is hardcoded to 5, the number of columns without
customization. Adding a new column doesn't change that value.

The fix has been to force the colspan at 99, the maximum value for
colspans. Using that value will always render the row to fill the table.

opw-1936088

closes odoo/odoo#31951

Signed-off-by: default avatarJulien Castiaux <Julien00859@users.noreply.github.com>
parent 80032892
No related branches found
No related tags found
No related merge requests found
......@@ -116,14 +116,14 @@
</td>
</t>
<t t-if="line.display_type == 'line_section'">
<td t-att-colspan="colspan">
<td t-att-colspan="99">
<span t-field="line.name"/>
</td>
<t t-set="current_section" t-value="line"/>
<t t-set="current_subtotal" t-value="0"/>
</t>
<t t-if="line.display_type == 'line_note'">
<td t-att-colspan="colspan">
<td t-att-colspan="99">
<span t-field="line.name"/>
</td>
</t>
......@@ -131,7 +131,7 @@
<t t-if="current_section and (line_last or doc.order_line[line_index+1].display_type == 'line_section')">
<tr class="is-subtotal text-right">
<td t-att-colspan="colspan">
<td t-att-colspan="99">
<strong class="mr16">Subtotal</strong>
<span
t-esc="current_subtotal"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment