-
- Downloads
[IMP] phone_validation: add blacklist mechanism
PURPOSE SMS are a powerful marketing tool. For instance it is perfect to announce a sale or to communicate a coupon code, to welcome a new customer in a fidelity program, ... Purpose of this task is to integrate SMS sending in batch in mass mailing. It will use same mailing objects but sending SMS instead of emails. Some metrics and flows will have to be slightly updated at the same time. SPECIFICATIONS Purpose of this commit is to add a blacklist mechanism for phone numbers used to send SMS like what already exists for email addresses when sending emails. Define a new phone.blacklist model, holding a number and the state of the blacklist (active field), as well as tools methods to access it. Make it as private as possible, accessing it in sudo once access are granted. Also clean phone validation tools: lessen number of tool functions and update caller to simplify code readability. Some fixes are also included in this commit, notably blank spaces cleaning in phone numbers. Improve phone.validation.mixin to add a tool method computing a sanitized number, in addition to formatting it to national / international. Define a new mail.thread.phone mixin computing the blacklist status of a record. This mixin * inherit from phone.validation.mixin in order to have access to some base phone number parsing capabilities; * computes a sanitized phone number based on ´´_phone_get_number_fields´´. It takes first sanitized value, trying each field returned by the method. That means one sanitized phone number is available per record even if several fields are available; * compute blacklist state of records. It is based on phone.blacklist model and give an easy-to-use field and API to manipulate blacklisted records; * give some API methods : * ``_phone_set_blacklisted``: set recordset as blacklisted; * ``_phone_reset_blacklisted``: reactivate recordset (even if not blacklisted this method can be called safely); Put menus in technical in order to have access to it. Add a Phone / SMS menu below "Email" and use it to store SMS / Phone actions. Finally prepare tests addition by performing some light cleaning while adding blacklist tests. Purpose is to ease future tests related to SMS. LINKS Task 1997464 PR #34424 Original SMS addition: Task 1922163 (4287481b)
Showing
- addons/phone_validation/__manifest__.py 18 additions, 5 deletionsaddons/phone_validation/__manifest__.py
- addons/phone_validation/models/__init__.py 3 additions, 1 deletionaddons/phone_validation/models/__init__.py
- addons/phone_validation/models/mail_thread_phone.py 103 additions, 0 deletionsaddons/phone_validation/models/mail_thread_phone.py
- addons/phone_validation/models/phone_blacklist.py 109 additions, 0 deletionsaddons/phone_validation/models/phone_blacklist.py
- addons/phone_validation/models/phone_validation_mixin.py 19 additions, 0 deletionsaddons/phone_validation/models/phone_validation_mixin.py
- addons/phone_validation/security/ir.model.access.csv 3 additions, 0 deletionsaddons/phone_validation/security/ir.model.access.csv
- addons/phone_validation/tools/phone_validation.py 17 additions, 21 deletionsaddons/phone_validation/tools/phone_validation.py
- addons/phone_validation/views/phone_blacklist_views.xml 72 additions, 0 deletionsaddons/phone_validation/views/phone_blacklist_views.xml
- addons/sms/__manifest__.py 2 additions, 1 deletionaddons/sms/__manifest__.py
- addons/sms/models/__init__.py 1 addition, 0 deletionsaddons/sms/models/__init__.py
- addons/sms/models/mail_thread.py 3 additions, 3 deletionsaddons/sms/models/mail_thread.py
- addons/sms/models/mail_thread_phone.py 16 additions, 0 deletionsaddons/sms/models/mail_thread_phone.py
- addons/sms/models/res_partner.py 2 additions, 1 deletionaddons/sms/models/res_partner.py
- addons/sms/tests/common.py 4 additions, 4 deletionsaddons/sms/tests/common.py
- addons/sms/views/res_partner_views.xml 3 additions, 0 deletionsaddons/sms/views/res_partner_views.xml
- addons/sms/views/sms_sms_views.xml 4 additions, 2 deletionsaddons/sms/views/sms_sms_views.xml
- addons/sms/views/sms_template_views.xml 5 additions, 1 deletionaddons/sms/views/sms_template_views.xml
- addons/sms/wizard/sms_composer.py 2 additions, 1 deletionaddons/sms/wizard/sms_composer.py
- addons/test_mail_full/models/test_mail_models.py 22 additions, 0 deletionsaddons/test_mail_full/models/test_mail_models.py
- addons/test_mail_full/security/ir.model.access.csv 2 additions, 0 deletionsaddons/test_mail_full/security/ir.model.access.csv
Loading
Please register or sign in to comment