Skip to content
Snippets Groups Projects
Commit 94a735ec authored by fedegobea's avatar fedegobea Committed by Joseph Caburnay
Browse files

[FIX] point_of_sale: editing customers always asking to change name


Hi i detected an issue on POS, to reproduce just get into a customer on the POS UI, change something else than the name, then try to save changes, this trigger the if in line 47, making the user to mandatory edit the name field then save again and it works.

The only change on the file is on line 47 where I check if the name is already on the prop so that it works as intended.

Its a mild UX issue with a very easy fix. hope you can upload it soon to the repo so that users on Odoo SaaS or users with no code skills dont have this Issue anymore-

Best regards

closes odoo/odoo#63281

Signed-off-by: default avatarpimodoo <pimodoo@users.noreply.github.com>
parent b7400c08
No related branches found
No related tags found
No related merge requests found
......@@ -44,7 +44,8 @@ odoo.define('point_of_sale.ClientDetailsEdit', function(require) {
processedChanges[key] = value;
}
}
if (!processedChanges.name) {
if ((!this.props.partner.name && !processedChanges.name) ||
processedChanges.name === '' ){
return this.showPopup('ErrorPopup', {
title: _('A Customer Name Is Required'),
});
......
Argentina, 12/12/2020
I hereby agree to the terms of the Odoo Individual Contributor License
Agreement v1.0.
I declare that I am authorized and able to make this agreement and sign this
declaration.
Signed,
Federico Gobea 65693362+fedegobea@users.noreply.github.com https://github.com/fedegobea
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment