Skip to content
Snippets Groups Projects
Commit 94bb547a authored by Laurent Stukkens (LTU)'s avatar Laurent Stukkens (LTU)
Browse files

[FIX] website_form: prevent error on drop thumbnail in editor in Safari


Issue

	When using the website editor in Safari browser, an error occurs
	when dropping the form builder thumbnail into the editor.

Step to Reproduce

	- Install website and web_editor applications
	- Use Safari browser
	- Got to Website
	- Click on Edit
	- Drag and drop the From Builder thumbnail from the left panel
	  into the editor

Cause

	The javascript function Node.insertBefore(newNode, referenceNode) needs to
	be called on referenceNode's immediate parent.
	Using DocumentFragment.querySelector(':first-child')
	returns the first child of the first element in the fragment which triggers
	this issue. The reason why Chrome accepts and handles this correctly
	remains a mistery to me ;o)

Solution

	Call Node.insertBefore() method on the immediate parent of the
	node the insertion has to be performed before.
	So use .childNodes[0] instead of .querySelector(':first-child').

task-2271745

closes odoo/odoo#52520

X-original-commit: dd9ce45c09f8f2181eb48639c0e3ea6617260510
Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
parent f0420013
No related branches found
No related tags found
No related merge requests found
......@@ -535,7 +535,7 @@ options.registry.WebsiteFormEditor = FormEditor.extend({
return;
}
// Add Action select
const firstOption = uiFragment.querySelector(':first-child');
const firstOption = uiFragment.childNodes[0];
uiFragment.insertBefore(this.selectActionEl.cloneNode(true), firstOption);
// Add Action related options
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment