-
- Downloads
[FIX] web: fix duplicate changes in form view
Before this commit, in some cases, clicking on 'save' button, then on other buttons (like 'validate' in invoices) had the unfortunate effect of applying twice the changes in some cases. More specifically the problem appears when: 1. an onchange is triggered (for example, taxes in invoices) 2. the user clicks on 'save', buttons are disabled 3. the 'save' actions is completed, the buttons are enabled, but the on_button_save still does some work: triggering event, and reloading the view 4. the user clicks on 'validate' 5. the onchange completes, this triggers some more work Our only protection against such interactions is right now the fact that buttons are disabled/enabled. In my opinion, there should be a way to guarantee that actions are properly serialized (that is actually what a mutex is for... just saying). But the code of the form view/list view is too coupled, and such changes are quite dangerous. A real refactoring of those is needed at some point in the future.
Loading
Please register or sign in to comment