[IMP] Replace meaningless fontawesome icons by better ones

Replaced :
- fa-xing by fa-bookmark-o
- fa-github by fa-users
- fa-strikethrough by fa-usd
Impacted modules : account_analytic_default, event, product, sale

addons/account_analytic_default/account_analytic_default_view.xml

@@ -81,7 +81,7 @@
             <field name="arch" type="xml">
                 <div name="button_box" position="inside">
                     <button class="oe_stat_button" name= "%(action_product_default_list)d" type="action" 
-                        groups="analytic.group_analytic_accounting" icon="fa-xing">
+                        groups="analytic.group_analytic_accounting" icon="fa-bookmark-o">
                         <field string="Analytic Rules" name="rules_count" widget="statinfo" />
                     </button>
                 </div>
@@ -95,7 +95,7 @@
             <field name="arch" type="xml">
                 <div name="button_box" position="inside">
                     <button class="oe_stat_button" name= "action_view_rules" type="object" 
-                        groups="analytic.group_analytic_accounting" icon="fa-xing">
+                        groups="analytic.group_analytic_accounting" icon="fa-bookmark-o">
                         <field string="Analytic Rules" name="rules_count" widget="statinfo" />
                     </button>
                 </div>

addons/event/event_view.xml

@@ -69,7 +69,7 @@
                             <button name="%(event.act_event_registration_from_event)d"
                                 type="action"
                                 class="oe_stat_button oe_event_attendee_button"
-                                icon="fa-github"
+                                icon="fa-users"
                                 help="Register with this event">
                                 <field name="seats_expected" widget="statinfo" string="Attendees"/>
                             </button>

addons/product/product_view.xml

@@ -253,7 +253,7 @@
                     <field name="default_code" attrs="{'invisible': [('product_variant_count', '>', 1)]}"/>
                 </field>
                 <div name="button_box" position="inside">
-                    <button class="oe_stat_button" string="Variant Prices"  name="%(variants_template_action)d" type="action" icon="fa-strikethrough"/>
+                    <button class="oe_stat_button" string="Variant Prices"  name="%(variants_template_action)d" type="action" icon="fa-usd"/>
                     <button class="oe_stat_button" name="%(product.product_variant_action)d" type="action" icon="fa-sitemap">
                         <field string="List of Variants" name="product_variant_count" widget="statinfo" />
                     </button>

addons/sale/res_partner_view.xml

@@ -34,7 +34,7 @@
                     <field name="sale_order_count"/>
                 </field>
                 <xpath expr="//div[@class='oe_kanban_partner_links']" position="inside">
-                    <span t-if="record.sale_order_count.value>0" class="badge"><i class="fa fa-fw fa-strikethrough"/><t t-esc="record.sale_order_count.value"/></span>
+                    <span t-if="record.sale_order_count.value>0" class="badge"><i class="fa fa-fw fa-usd"/><t t-esc="record.sale_order_count.value"/></span>
                 </xpath>
             </field>
         </record>
@@ -49,7 +49,7 @@
                 <div name="button_box" position="inside">
                     <button class="oe_stat_button" type="action" name="%(sale.act_res_partner_2_sale_order)d" 
                         attrs="{'invisible': [('customer', '=', False)]}"
-                        icon="fa-strikethrough">
+                        icon="fa-usd">
                         <field string="Sales" name="sale_order_count" widget="statinfo"/>
                     </button>     
                 </div>

addons/sale/sale_view.xml

@@ -595,7 +595,7 @@
             <field name="arch" type="xml">
                 <div name="button_box" position="inside">
                     <button class="oe_stat_button" name="action_view_sales"
-                        type="object" icon="fa-strikethrough">
+                        type="object" icon="fa-usd">
                         <field string="Sales" name="sales_count" widget="statinfo" />
                     </button>
                 </div>
@@ -610,7 +610,7 @@
             <field name="arch" type="xml">
                 <div name="button_box" position="inside">
                     <button class="oe_stat_button" name="action_view_sales" 
-                        type="object" icon="fa-strikethrough">
+                        type="object" icon="fa-usd">
                         <field string="Sales" name="sales_count" widget="statinfo" />
                     </button>
                 </div>