Skip to content
Snippets Groups Projects
Commit a7c32029 authored by Aaron Bohy's avatar Aaron Bohy
Browse files

[FIX] web: action service: sanitize action.domain


When it is unset, the domain of an action can be either false or
the empty string, which in both cases means []. Before this commit,
we didn't process the domain in thoses cases (i.e. we kept the
false or empty string value). However, having an empty string as
domain could cause issues if it is manipulated by Domain/pyutils.
In particular, in stock.picking, clicking on "Insert menu in
spreadsheet" crashed before this commit.

To prevent those issues from happening, this commit sanitizes the
domain of the action at the first entry point, such that it's
always an array (the empty array in our case).

This commit comes with a test in enterprise, which reproduces the
scenario given above, as we couldn't find framework and blackbox
scenario to highlight it.

closes odoo/odoo#135369

X-original-commit: 0fde590b
Related: odoo/enterprise#47363
Signed-off-by: default avatarSamuel Degueldre (sad) <sad@odoo.com>
Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
parent 23f6f654
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment