[IMP] core: reporting of browser logs / errors during setup
Improve handling of JS logging in headless runner in order to avoid losing logs
and errors e.g. the issue fixed by odoo/odoo#41231 passed because it occurred
during module loading, which happens during initial page loading (browser_js >
navigate_to > _websocket_wait_event), which ignored logs (and exceptions though
here it's a console.error log), and as a result reported no failure (and would
simply miss that specific test as well as every test following it).
This requires additional modifications as we have a fair amount of silent
failures (exceptions or logging.error calls) at the moment:
- downgrade one error to a warning (which becomes an info at the python level)
- cleanup some synthetic / mock errors to better match what comes over RPC (and avoid transient or setup failures)
- tours which end in an action, leading to JS code executing during browser cleanup (and blowing up)
- if the last step triggers a default (implicit) run, replace by a no-op
- fix tours for which that does not work by either modifying the last step or adding an additional check step
closes odoo/odoo#41334
Related: odoo/enterprise#7771
Signed-off-by:
Xavier Morel (xmo) <xmo@odoo.com>
No related branches found
No related tags found
Showing
- addons/bus/static/src/js/crosstab_bus.js 1 addition, 1 deletionaddons/bus/static/src/js/crosstab_bus.js
- addons/note/models/res_users.py 5 additions, 7 deletionsaddons/note/models/res_users.py
- addons/point_of_sale/static/src/js/models.js 1 addition, 1 deletionaddons/point_of_sale/static/src/js/models.js
- addons/test_website/static/tests/tours/reset_views.js 13 additions, 4 deletionsaddons/test_website/static/tests/tours/reset_views.js
- addons/web/static/src/js/boot.js 1 addition, 2 deletionsaddons/web/static/src/js/boot.js
- addons/web/static/src/js/core/ajax.js 2 additions, 1 deletionaddons/web/static/src/js/core/ajax.js
- addons/web/static/tests/views/calendar_tests.js 2 additions, 2 deletionsaddons/web/static/tests/views/calendar_tests.js
- addons/web_tour/static/src/js/tour_manager.js 3 additions, 0 deletionsaddons/web_tour/static/src/js/tour_manager.js
- addons/website/static/src/js/content/website_root.js 1 addition, 0 deletionsaddons/website/static/src/js/content/website_root.js
- addons/website/static/tests/tours/dashboard_tour.js 5 additions, 4 deletionsaddons/website/static/tests/tours/dashboard_tour.js
- addons/website/static/tests/tours/reset_password.js 1 addition, 16 deletionsaddons/website/static/tests/tours/reset_password.js
- odoo/addons/base/tests/test_orm.py 1 addition, 1 deletionodoo/addons/base/tests/test_orm.py
- odoo/addons/test_access_rights/tests/test_ir_rules.py 4 additions, 0 deletionsodoo/addons/test_access_rights/tests/test_ir_rules.py
- odoo/netsvc.py 1 addition, 1 deletionodoo/netsvc.py
- odoo/tests/common.py 160 additions, 41 deletionsodoo/tests/common.py
Loading
Please register or sign in to comment