Skip to content
Snippets Groups Projects
Commit cfd5c906 authored by Goffin Simon's avatar Goffin Simon
Browse files

[FIX] hr_holidays: Access error when requesting a new leave


Steps to reproduce the bug:
- Create an hr.leave.allocation with mode = 'By Employee Tag'
- Select Employee Tag = 'Employee'
- Set all the other required values
- Log with Demo User(Marc Demo)
- Go to Leaves > My Leaves > New Request

Bug:

An access right error was raised due to the record rule: "Allocations: employee: read own"
With this record rule the user can only read the hr.leave.allocation linked to his employee's user.
But with allocations in mode 'By Employee Tag', in the function get_days it tried to compute
the 'number_of_hours_display' of all the allocations linked to the current employee's user and
in the function _compute_number_of_hours_display, it also computes the parent_id of these allocations.
As the parent_id is not linked to the employee's user, it raised an access right error.

opw:2006686

closes odoo/odoo#34236

Signed-off-by: default avatarSimon Goffin (sig) <sig@openerp.com>
parent 97cd3dfd
No related branches found
No related tags found
No related merge requests found
......@@ -173,7 +173,7 @@ class HolidaysType(models.Model):
if request.leave_type_request_unit == 'hour'
else request.number_of_days)
for allocation in allocations:
for allocation in allocations.sudo():
status_dict = result[allocation.holiday_status_id.id]
if allocation.state == 'validate':
# note: add only validated allocation even for the virtual
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment