-
- Downloads
[FIX] website: prevent btn on 404 page to be clicked before JS loaded
Before this commit, it was possible to click on the "Create page" button before the JS was loaded, as that button is a simple link with a href. But that link is supposed to be handled by the JS which transform the GET href link to a fake form submit to send a POST request to the `/website/add` controller. If the user clicks before the JS had the chance to handle that click and do the "transformation", the controller will reject the GET request and a raw 405 error page will be shown. Now, we wait for the JS to be fully loaded before allowing user to click on this button. The fix is made globally as it should be the case of every link related to this behavior. Note that the `/website/add` controller was changed from GET to POST with commit [1]. It most likely forgot to adapt the button from the 404 page which was later done with [2] by using the `post_link` util class introduced with [3] (for need of website_blog at the time). [1]: https://github.com/odoo/odoo/commit/714f0aa07f25e8a88a778e8b21c79b48e9801231 [2]: https://github.com/odoo/odoo/commit/2c85c1cb6ee0f6000cd2db182d5b8cfd3d040876 [3]: https://github.com/odoo/odoo/commit/0f2cada32319b3910d6ace6d412cfa94a646c9c7 task-2847785 closes odoo/odoo#90869 Signed-off-by:Quentin Smetz (qsm) <qsm@odoo.com>
Loading
Please register or sign in to comment