Skip to content
Snippets Groups Projects
Commit ddd3e08f authored by Denis Ledoux's avatar Denis Ledoux
Browse files

[FIX] im_livecat: `HttpRequest.render` returns a Response

This revision is related to 100d604c

The above revision aimed to add the correct `content-type` headers,
the according route returning Javascript and not simple html.

HttpRequest.render` returns a Response,
and `make_response` doesn't expect a Response as first argument.

In other words, this is not possible to make Reponse from a Response.

`HttpRequest.render` accepts kwargs, including `headers`.

opw-666898
parent 59ce9a0e
Branches
Tags
No related merge requests found
......@@ -30,8 +30,7 @@ class LivechatController(http.Controller):
username = kwargs.get("username", _("Visitor"))
channel = request.env['im_livechat.channel'].sudo().browse(channel_id)
info = request.env['im_livechat.channel'].get_livechat_info(channel.id, username=username)
js = request.render('im_livechat.loader', {'info': info, 'web_session_required': True})
return request.make_response(js, headers=[('Content-Type', 'application/javascript')])
return request.render('im_livechat.loader', {'info': info, 'web_session_required': True}, headers=[('Content-Type', 'application/javascript')])
@http.route('/im_livechat/init', type='json', auth="public")
def livechat_init(self, channel_id):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment