-
- Downloads
[FIX] web: graph rendering when in DOM
Backported fixes: 1. [IMP] web: GraphView: remove hack to render in DOM - ref. 166319fa - fully backported. This commit backports the fix that removes the hack for rendering graphs (delay in a setTimeout), so that the graph is rendered when it is in the DOM. 2. [IMP] web: restore scroll position - ref. 4e204ed2 - partially backported: only keeps `on_attach_callback` and `on_detach_callback` in the abstract_controller and in the abstract_renderer. This commit backports the use of the hooks methods `on_attach_callback` and `on_detach_callback` in abstract controller and renderer, so that the controller of any view warns the renderer when it has been attached in (or detach from) the DOM. Also, this commit adds `on_attach_callback` and `on_detach_callback` for the dashboard app, so that the graph view is correctly rendered. Fixes #24092
Showing
- addons/board/static/src/js/dashboard.js 26 additions, 0 deletionsaddons/board/static/src/js/dashboard.js
- addons/board/static/tests/dashboard_tests.js 44 additions, 0 deletionsaddons/board/static/tests/dashboard_tests.js
- addons/web/static/src/js/views/abstract_controller.js 12 additions, 0 deletionsaddons/web/static/src/js/views/abstract_controller.js
- addons/web/static/src/js/views/abstract_renderer.js 8 additions, 0 deletionsaddons/web/static/src/js/views/abstract_renderer.js
- addons/web/static/src/js/views/form/form_controller.js 1 addition, 0 deletionsaddons/web/static/src/js/views/form/form_controller.js
- addons/web/static/src/js/views/graph/graph_renderer.js 48 additions, 16 deletionsaddons/web/static/src/js/views/graph/graph_renderer.js
Loading
Please register or sign in to comment