When codice fiscale is not the same as the partita IVA, the template was
utilising the wrong value for IdCodice in <IdTrasmittente>. It should
use the value of codice fiscale, and if it's not found, then use the vat
value (e.g. when it's not an Italian company).

closes odoo/odoo#86621

X-original-commit: e961ff22
Signed-off-by: Josse Colpaert <jco@odoo.com>

The issue is that the config param is data, which means that when the
module is updated, the config parameter will be updated (i.e. reset to
the 'demo' state), which will cause havoc on client databases. Even if
we set the record to 'noupdate=1', the existing clients will have the
record updated.

The solution is to remove the config param from the data entirely, thus
preventing it from being updated when updating the module, and instead
have a 'post_init_hook' that sets the parameter to 'demo' (this will
only happen when the module is installed, and never again).

closes odoo/odoo#86607

X-original-commit: 1d3cd7ee
Signed-off-by: Josse Colpaert <jco@odoo.com>

PrezzoUnitario causes an error when the discount is 100% as it tries to
divide by zero. Fix this by just using the unit price when the discount
is 100%.

closes odoo/odoo#86614

X-original-commit: 23e84145
Signed-off-by: Josse Colpaert <jco@odoo.com>

The EDI rejects the xml if the <IdDocumento/> is longer than 20
characters long.

X-original-commit: 2c76293c
Part-of: odoo/odoo#86614

*: hr_holidays, im_livechat, mail, mail_bot, sms, snailmail, test_mail,
website_livechat, website_slides.

Mail tests are currently relying on this during tests to make env, widget,
data available. We don't wan't to add magic keys to this anymore.

task-2792108

closes odoo/odoo#86559

Related: odoo/enterprise#25341
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Task-2793280

closes odoo/odoo#86449

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Task-2793280

closes odoo/odoo#86443

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Consider the following case:

1) Create a 42% cash basis tax, impacting different grids on each repartition line
2) Create a misc entry using this tax, with the same lines as an invoice, with base amount of 100
3) Create a payment and reconcile it with the invoice-like move from step 2. This will create a cash basis move.
4) Cancel reconciliation
===> In the tax report, instead of seeing 0 in the base grid, we see 200. Amounts are doubled instead of being cancelled, they shouldn't. Tax grid is fine.

This is due to the fact tax_tag_invert is going to be computed, and will hence not have the same value as on the original move, since debit and credit on base and tax lines are inverted in the reverse move. Tax line is fine because it relies on tax_repartition_line_id, which is kept from the original move.

We now force keeping the same value for those moves as in the original one, to force full cancellation.

OPW 2769340

closes odoo/odoo#86229

X-original-commit: 338c2e90
Related: odoo/enterprise#25182
Signed-off-by: Laurent Smet <las@odoo.com>

Prior this commit,`o_AttachmentViewer_toolbar`,
`o_AttachmentViewer_viewIframe` and buttons used CSS properties with
arbitrary values.

To keep the layout consistent and remove more raw css, this commit uses
component and utility classes instead.

task-2781992

closes odoo/odoo#85772

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

Part-of: odoo/odoo#85772

Prior to this commit:
- The test tour was falling in some circumstances, when additional reads
  were done right after the last step.

After this commit:
- Adding the last step which is returning the the project app menu will
  prevent having those additional reads after the last step.

closes odoo/odoo#86558

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

We have added the name of the group to Email Content to minimize the
indexing on xpath.

Task-2710557

closes odoo/odoo#86555

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

A file was accidentally pushed in the context of a last rebase
prior to merge.
See odoo/odoo#82634

closes odoo/odoo#86564

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

Move model definition files from `models/thing/thing.js` to
`models/thing.js` and remove the now empty intermediate directory.

Task-2759582
 * = calendar, crm_livechat, hr, im_livechat, mail_bot, sms, snailmail,
     website_livechat, website_slides

closes odoo/odoo#86464

Related: odoo/enterprise#25291
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

 * : mail_bot, website_livechat
Task-2759560

Part-of: odoo/odoo#86464

Prior this commit, the dark color was the same as the Bootstrap color.
It wasn't contrasted enough and was therefore replaced by raw css in
some situations.

To keep consistency with the overall layout, this commit applies the
darkest gray as the $dark variable to improve the value and now
encourages the use of utility classes instead of raw values.

task-2788931

closes odoo/odoo#86046

Related: odoo/enterprise#25100
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

In a recent fix, the default values generated for datetime fields in
custom filter was incorrectly set, as the returned date objects were
lost instead of being assigned.

This commit restores the intended behavior.

closes odoo/odoo#86538

X-original-commit: 2720c5be
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

In the mobile review of all apps, some behaviors have to be corrected.

After this commit :
- When you want to select a feedback template to send, the list is showed with less information so that it's easier to read.
- The ask feedback is open to any employee of the company, not only the users of the app. The email will be sent with a link available to anyone.
- When state is Done, the add buttons on skills does not appear anymore.

TaskID : 2743968 [Appraisal] Usability

closes odoo/odoo#84053

Related: odoo/enterprise#24044
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Prior this commit, the popover arrow was in raw SCSS and used only
the four basic directions (top, right, bottom, left).

After this commit, the popover uses the Bootstrap arrow and this
arrow can also use the additional directions defined in
`position_hooks.js`.

It also revamp the SCSS of the component.

task-2748120

closes odoo/odoo#83646

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

Part-of: odoo/odoo#83646

Changes:
- remove all of o-popper-position... auto applied classes system
- add a onPositioned callback to the options
  Usage
    usePosition(reference, {
      /**
       * @param {HTMLElement} popperElement
       * @param {{
       *  direction: "top" | "right" | "bottom" | "left",
       *  variant: "start" | "middle" | "end"
       *  top: number,
       *  left: number,
       * }} position
       */
      onPositioned: (popperElement, position) => {
          const { direction } = position;
          // ...
      }
    });

Part-of: odoo/odoo#83646

As component.el is removed: see https://github.com/odoo/owl/blob/master/CHANGELOG.md#9-componentel-is-removed

Part-of: odoo/odoo#83646

Prior to this commit an 'oi-fw' icon width was assigned directly to its
:pseudoelement and eventually refined according to sizes classes.

Despite being useful in some circumstances, this behavior was causing
inconsistencies when 'oi-fw' icons were rendered beside 'fa-fw' ones.

This commit reviews how fixed-width icons are achieved, providing a more
consistent visual result between '.fa' and '.oi' classes.

task-2795108

closes odoo/odoo#86508

Signed-off-by: Pierre Paridans (app) <app@odoo.com>

Since [1] when resetting the background color of the header, the footer
or the copyright, the 'menu-custom' property is saved as the 'false'
string.
There is no visual effect of this problem, but in case that property is
used in an SCSS `color-yiq` function call, it will trigger an error.

This commit solves this by removing the root cause of this 'false'
string: during the initialisation of color palettes a list of named
colors is built by browsing the color buttons and associating their
data-color attribute to their background-color, except for buttons
containing a gradient color.
Unfortunately this inventory also looked at the "Custom" gradient
button: this button has no background color (and was thus not detected
as being a gradient and therefore not excluded from the inventory) and
it has data-color="false". It therefore introduced a mapping between ""
and "false" - thus making the reset operation's empty string mapped to
the "false" string. This commit removes that button from the named
colors inventory.

Steps to reproduce:
- select the header
- open the "Colors" palette
- click on the None button (the trashcan icon)
=> the customization properties attachment contained a line
```
'menu-custom': 'false',
```

[1]: https://github.com/odoo/odoo/commit/a48a30f954afcb6ff3a59c4f32b05fd0c2cfcd2b



task-2633169

closes odoo/odoo#86548

X-original-commit: 2f28c37f
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Query counter tests related to account composer are actually dependent on
l10n due to extra queries, related to account.move fields and/or COA
specific code. Moreover some COA might skip or delay the sending, leading to
emails not being sent.

Purpose would be to run those tests only with generic_coa. Those tests will
be moved and improved soon, removing it currently to avoid frictions with
L10N builds.

This reverts odoo/odoo@d0e0db3b8eee381def04442ddaecfb82ff9859cc

closes odoo/odoo#86540

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#86279

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#86265

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#86173

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#86168

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#85940

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#85592

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Since https://github.com/odoo/odoo/commit/cb6c6224be4eaa80091f51f957059de889332e68


we are now raising possible errors when uploading an invoice.
In 14.0+ we are allowing via a redirect warning to change the status of
the currency without changing the page but the upload only starts when
you change the uploaded file.
So the following flow does not work:
    - Try to upload a bill with MXN currency
    - With MXN being inactive, it raises an error. Using the redirect warning action
      we activate the currency, clos the modale window and try to upload
      again.
    - The upload won't work until we refresh the page, because the value
      of the input file does not change (or we need to select another
      one, then the first one again)
This change reset the file input if there is an error raised during the
upload allowing to select the same file more than once without reloading.

closes odoo/odoo#86539

X-original-commit: 4bfc7507
Signed-off-by: William André (wan) <wan@odoo.com>

Current behavior:
All batch transfers are shown in the tree view. But only the one for the allowed companies should be in the list

Steps to reproduce:
- Be in a multicompany environnement
- Activate batch picking
- Go in Inventory/Batch transfers

opw-2752617

closes odoo/odoo#86531

X-original-commit: 8415b48c
Signed-off-by: Tiffany Chang <tic@odoo.com>
Signed-off-by: Engels Robin (roen) <roen@odoo.com>

The event is no longer bound since 0df4b002

And it's fine in this case : the form view does not need to be updated when
removing a pending attachment from composer.

closes odoo/odoo#86491

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Task-2793280

closes odoo/odoo#86467

Signed-off-by: Ooming <wil@odoo.com>

Task-2793280

closes odoo/odoo#86455

Signed-off-by: Ooming <wil@odoo.com>

Some payments may be confirmed asynchronously, and we need to be aware
of their status, even if they are not in a "checkout session complete"
event. Relying on successful payment or setup intents instead manage
more use cases.

task-2733725

closes odoo/odoo#84150

Related: odoo/upgrade#3350
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

*: calendar, hr, hr_holidays, im_livechat, mail, mail_bot, note, sms, snailmail,
website_livechat, website_slides.

This commit prepares the removal of beforeEach function in the
mail test suite. Cleanup was relying on beforeEach adding widgets,
components, unpatch method 'this'. We need to clean things up without
using either beforeEach or 'this'.

task-2792108

closes odoo/odoo#86526

Related: odoo/enterprise#25326
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Before this commit, any field requested to `_binary_record_content()`
when the model was `ir.attachment` would be considered as `raw`.

This assumption works at the moment but could lead to unexpected
behavior down the line.

see https://github.com/odoo/odoo/pull/86005#discussion_r824420219



closes odoo/odoo#86524

X-original-commit: eeb93287f9a9027d0ce22f9fd3305a7ab081d69f
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

closes odoo/odoo#86521

X-original-commit: a08f4e00
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>