Steps to reproduce:
- create and send a quotation
- make a failed payment (through cutomer preview)
- create and send a second quotation to the same customer
- make a succesful payment this time
- redirect takes to the wrong quotation (failed one)

Bug:
polling the processed payments initially returns both transaction
but the following polls only returns the rejected payment
(introduced in [1] processed transactions are filtered out)
since there's only a single transaction, redirect takes to it

Fix:
if there's only a single succesful transaction (regardless of the rest)
it means the current payment was successfull so we redirect to it

opw-2954162

[1]:https://github.com/odoo/odoo/pull/31741/commits/7612659565ee24f1c878b81e6c86b5780fbd5a3d



closes odoo/odoo#99969

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

In this commit, we add data of amortizations accounts and correct the
accumulated amortization accounts (now they are of the fixed asset
type) to be consistent with the Argentine chart of accounts.

For each accumulated amortization account we have an expense type
amortization account.

closes odoo/odoo#97534

Signed-off-by: Josse Colpaert <jco@odoo.com>

Following the steps that changed every quantity in a matrix, the next
step was triggered after at least one sale order line's quantity was
changed. Due to the number of lines created, one of the so lines was
sometimes not updated before the next step, which produces an error in
the final sale_count.

In order to check the total and ensure every line was updated, we set
the partner sooner in the tour, which in turn sets the pricelist used to
get the price of each line. Thus allowing a check on the subtotal.

Backport of commit-af1e67aa2c6c676479ee4ea73106bcabd20c621e

closes odoo/odoo#100273

Signed-off-by: Morgane Demesmaeker <edm@odoo.com>

Steps to reproduce:
- Create a transfer and choose whatever operation
- Enable detailed operations option for the operation
- Check availability and set quantities
- Cancel the transfer then Go to Product Moves

Current behavior:
- todo filter is broken, it shows canceled moves

Desired behavior:
- Show only moves that are assigned or waiting

- Task id: #2981249

closes odoo/odoo#100265

Signed-off-by: Tiffany Chang <tic@odoo.com>

On October 3rd 2022 the Google OOB authentication flow will stop working.

From that date on, this module will stop working since it uses the
access_token obtained in the `google_drive` module to create the requested
spreadsheet inside the user's own Google Drive account.

Instead we will display instructions to the users to allow them to
manually create the requested document.

task-2977578

closes odoo/odoo#99988

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Cookies should be used internally by the web UI. The server-side is not supposed to be aware of it at all.

Reverts:
https://github.com/odoo/odoo/pull/88745

Based on https://github.com/odoo/odoo/pull/93812


discussion. It has been decided to revert the fix to avoid further unattended behaviours.

closes odoo/odoo#100075

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The comment was introduced alongside its related line with [1].
The line was removed with [2] but its comment was not, leading to
confusion now.
Instead of removing it in master, might as well remove the confusion in
lower version..

[1]: https://github.com/odoo/odoo/commit/3542a27f9c4c44472184bbedc348ad646d46f20a
[2]: https://github.com/odoo/odoo/commit/0effbe3ca628460b9a0c257ea0bd6060c3eeb253



closes odoo/odoo#99963

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps to reproduce:
- enable multi currency in settings
- set different rates for multiple days
- create a vendor bill in a different currency
- create a second vendor bill
- fill the second bill using auto complete from the first one

Bug:
the correct currency rate isn't applied unless date is changed when
the source is a vendor bill not a purchase order

Fix:
update currency rate after adding a line with a different currency

opw-2890210

closes odoo/odoo#99640

Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

Small fixup of recent commit [1].

A regular user do not have delete right on iap.account model, hence
creating an access right error. We should allow him to delete accounts
without token so they will be re-created afterwards.

[1]:https://github.com/odoo/odoo/commit/974caef934b7a116b7375f05e047aea15ea960aa



closes odoo/odoo#99817

Signed-off-by: Florian Daloze (fda) <fda@odoo.com>

Search result is not used since switching to implementation with `read_group`.
The line is already removed in v14, but because it may significantly slow down
computation of the `purchased_product_qty` field, we should remove it in v13 too

opw-2971825

closes odoo/odoo#99800

Signed-off-by: Adrien Widart <awt@odoo.com>

closes odoo/odoo#99391

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:

  - Install purchase
  - Go to Settings and activate `Variant Grid Entry`
  - Create a new Requests for Quotation
  - Add a customer and add a product that has a variant min 2 variant
  - Wizard should ask for the variant
  - Select 1 variant by increasing quantity in the grid and confirm
  - Confirm order
  - Add again a product variant with the wizard

Issue:

  Price unit is not set on the new line.

Cause:

  In `_onchange_quantity` (triggered by the purchase_product_matrix
  module), we do not update price unit if order line
  is in state `purchase` or `done`.

Solution:

  Replace condition to not perform `_onchange_quantity` if order line
  has an invoice line.

opw-2956755

closes odoo/odoo#98960

Signed-off-by: Adrien Widart <awt@odoo.com>

Before, when using a cash basis tax in the bank reconciliation widget, the account chosen for the tax line corresponded to the tax transition account. This was wrong: since the entry is already reconciled, we want to use the actual repartition account, as nothing will move this amount from the transition account afterwards.

Indirectly linked to OPW 2865789

closes odoo/odoo#99427

Signed-off-by: Laurent Smet <las@odoo.com>

closes odoo/odoo#97435

Signed-off-by: William André (wan) <wan@odoo.com>

Before this patch, when we try to print an invoice without belonging to the group stock.group_stock_user, we get an Access Error.

Doing this patch, we are allowed to print the invoices as we skipped the mentioned ACL.

closes odoo/odoo#74728

Signed-off-by: William André (wan) <wan@odoo.com>

Steps to reproduce the bug:
- install eCommerce module with assets
- go to any product page
- check the source code with https://validator.schema.org/

Notice that the 'image' and 'url' microdata tags have no base url,
so the engine assumes http://schema.org/

 to be the base url. This
makes certain ad trackers such as facebook pixel unable to detect
the product being sold.

This commit adds the base_url field to both tags so that they are
correctly traced.

opw-2830058

closes odoo/odoo#97215

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

closes odoo/odoo#99087

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Currently, when creating an invoice from factur_x XML, the vendor is
identified by sequentially checking (in this order) the following
information :
- VAT number
- name
- email
However, when we generate a factur_x XML, we do not include
the partner's email address. This means that in some cases, two odoo
databases are not able to communicate bills/invoices properly.
This commit brings back a behavior that was unintentionally removed in
https://github.com/odoo/odoo/commit/d25fdafcd8eb4cfef14c2ef7ed8ad7785dd01b55



opw-2909408

closes odoo/odoo#98896

Signed-off-by: William André (wan) <wan@odoo.com>

closes odoo/odoo#99083

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Since the accounts without token are useless and could create errors
afterwards, we should delete them and automatically create a new one
with a new token in case force_create is set to True.

closes odoo/odoo#98858

Signed-off-by: Florian Daloze (fda) <fda@odoo.com>

Reverts [this commit] because it modified the format of float numbers in
exported xlsx files and we want to avoid introducing an error or
unwanted behavior in version 13, for which support will soon come to an
end.

[this commit]:https://github.com/odoo/odoo/commit/27ab24214dabfafc652280f680f7a650e7d98d2b



closes odoo/odoo#98975

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit, in invoice/bill, when changing
the account of a tax line while having one of the invoice
lines with tax 0%, the tax line was not displayed anymore.

The cause of the issue is that in _recompute_dynamic_lines
method, when setting the tax repartition lines to
recompute, we did not filter the 0 tax. The consequence was
that we had a delta between expected and current taxes,
although the line of tax 0% was not displayed anyway.
By filtering the 0 tax, we have expected taxes == current taxes,
so we do not have delta anymore, therefore no tax line to recompute.

opw-2901833

closes odoo/odoo#97663

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

This commit addresses a screen refresh problem.

closes odoo/odoo#98788

Task: 2961768
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

This PR adds the 'posted' filter by default on the journal items list
view, when coming from an account's form view.

opw-2896728

closes odoo/odoo#98183

Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

If datetimepickers were used too soon after page loading, they would use
the wrong format and UI options as the code in charge of initializing
those options was not fully lazy loaded yet.

With this patch, we prevent the tempusdominus lib to consider pickers
that are in a body that is marked by the lazyloader during the lazy
loading of JS files. We could potentially not add the lib attribute
(data-toggle="datetimepicker") on those elements and let the business
code initializing the pickers add it but that would not have been a
stable fix and it may be better this way as this works generically.

opw-2944720

closes odoo/odoo#98529

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Add Jose Moreno Hanshing

closes odoo/odoo#98329

Signed-off-by: Josse Colpaert <jco@odoo.com>

Backport of https://github.com/odoo/enterprise/commit/0a8aa0d48b17d2d428941b3bd11aca5d0a3422e9



Don't show the stock input/output accounts
in the reconciliation widget.

Steps to reproduce:

- A product category PC, costing method AVCO,
  automated valuation and custom stock input(STI)/output(STO)
  account (reconcile = True)
- A Journal Entry with the STI
  Move line :
  | Account | Debit | Credit |
  |---------|-------|--------|
  |   STI   |  0.0  |  50.0  |
  | XXXXXXX |  50.0 |   0.0  |

- Create a bank statement with amount corresponding with
  the journal entry then reconcile
-> Line for custom stock input STI account shows up in misc tab
   on reconciliation widget

Fetch all accounts relative to stock accounts properties, then
filter them in the domain.

opw-2792862

closes odoo/odoo#96131

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Reproduction:
1. Create a dynamic attribute "dyn_att" with a couple of values
2. Create a product template "dyn_prod" with those attribute values
3. Create an order for "dyn_prod", this will trigger creating a variant
4. Make sure to check Variant Grid Entry in Sales Settings
5. Open variant form view of dyn_prod and edit it to allow duplication
6. Duplicating it leads to an error

Reason: copying the variant is not possible and disabled here:
https://github.com/odoo/odoo/pull/38303

 For future convenience, maybe
it’s better to give a temporal working solution. The function
_create_first_product_variant is used in the product module but only
defined in its child module website_sale

Fix: copy the product template, create and return its first possible
variant. Added test for dynamic variant copy. change the definition
place of _create_first_product_variant to module product

opw-2790543

closes odoo/odoo#88075

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Exporting data incorrectly formats the float values of group headers

Steps to reproduce:
1. Install Planning
2. Open Planning and trigger the list view
3. Remove the default filter and add a group_by on employees
4. Export the data
5. The file produced doesn't have the same format for Allocated Hours in
   the group headers and in the line details

Solution:
Create formats for float and monetary values using the user's
preferences in decimal separator and decimal precision. For monetary
format, we use the biggest decimal precision used in the company
currencies.

opw-2864273

closes odoo/odoo#94534

Signed-off-by: Julien Castiaux <juc@odoo.com>

Searching by attributes works via a separate form. It has a copy of other search
parameters (`category`, `search`), but not `order`.

STEPS

1) enable View "Products Attribute's Filters" in eCommerce
2) enable View "Show Sort by" in eCommerce
3) Set sorting to specific value
4) Change Product Filters Attribute values
5) as you can see, the sorting set in Pt3 is lost....

opw-2956280

closes odoo/odoo#98553

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Steps to reproduce:

  - Install `website_event` module
  - Go to Events and edit `Design Fair Los Angeles` event
  - Edit the title and make it very long then save
  - Go to the Website then click on Events in the menu
  - Click on Customize and disable `Layout - Columns` to have
    a list view.

Issue:

  The cover is hidden on edited event.

Cause:

  It's a know issue:
  https://stackoverflow.com/questions/36247140/why-dont-flex-items-shrink-past-content-size



Solution:

  Set min-width: 0 to the div arround the title if screen size bigger
  then `sm`.

opw-2882533

closes odoo/odoo#95992

Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

Facebook no longer supports the option to see the profile pictures of
friends who have liked the page. So this commit removes the option
(which was no longer useful). See [same issue at WordPress].

[same issue at WordPress]: https://wordpress.org/support/topic/facebook-likebox-disappearance-of-the-faces-of-friends-who-like-the-page/



task-2950329

closes odoo/odoo#98177

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps to reproduce the issue:

- Notes app > Kanban view > Create a bunch of notes using
the + icon in the kanban view
- (optional) Modify the default order of the notes
- Add a new note using the quick add feature
- Don't modify the order of the notes and refresh the page
- The new note will be sent to the bottom of the note list
(off-screen if the list is long enough)

This happens because new notes have their sequence set to NULL, which
places them at the end of the list after ordering by sequence.

This commit sets the default sequence of a new note to 0, so that it
is placed at the top of the list and adds an additional sort on
'id desc' to consider the case where all notes have the same sequence.

opw-2924615

closes odoo/odoo#97023

Signed-off-by: stcc-odoo <stcc@odoo.com>

The model had name_get, but not _name_search, which leads to difference between
what user sees and what he get as search results.

This patch doesn't fix the issue completly, but adds more search results on
searching just by account move (e.g. invoice) name.

STEPS:

* open menu Analytic Items (account.analytic.line)
* make custom filter *Journal items contains "INV/"* (
`[["move_id","ilike","INV"]]` )

BEFORE: no items found even if you see such analytic items

---

opw-2691495

closes odoo/odoo#87156

Signed-off-by: William André (wan) <wan@odoo.com>

/my/account controller blocks name/vat/company_name updating if there are issued invoices.

However Before this commit, user can change name via /shop/address page

STEPS

1/ install sales, eCommerce,inventory,Accounting
2/ create a sales order from the portal page, validate and create an invoice from SO and post it
3/ Try to change the name from the Portal > Account
Result - not possible = correct
4/ Place a new SO by the same portal user and edit the name on the address before proceeding to checkout

[1]: https://github.com/odoo/odoo/blob/1f49528a4b198e8912beb33be921d2855c694e2e/addons/account/controllers/portal.py#L111-L113



opw-2848251

closes odoo/odoo#97686

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Consider this case:
Template A has 2 variants: KIT and NOKIT
KIT has a total cost of 100, NOKIT costs 50
When selling NOKIT, the current code will select the bom of KIT
to calculate the price_unit of NOKIT, which means that when
reconciling the aml of the invoice (amount = 100) with the aml of
the cogs move (amount = 50), it will be partial due to the difference
in amount. This alse messes with the balance sheet report.

This fix ensures that only boms directly related to the product
or for the generic template are selected.

opw-2918080

closes odoo/odoo#97453

Signed-off-by: Steve Van Essche <svs@odoo.com>