Some widgets allow the edition in readonly (e.g. boolean_toggle,
priority...). In this case, the changed value is saved directly.
Before this commit, this didn't work in (main) list views: the
widget was updated with the new value, but it wasn't saved in db,
so the change was lost at reload.

This was due to the list controller not being correctly aware of
its mode ('edit' or 'readonly'), on which the basic controller
relies to determine whether a change must be saved directly or
not.

With this commit, a list is always in 'readonly', except when a
row is being edited, in which case it is in 'edit'.

Issue reported on task 2288963

closes odoo/odoo#54049

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>

Issue

	- Install English and French languages
	- Create a customer contact and assign french as his language
	- Create a product with correct names in both languages.
	  For example 'French product name' and 'English product name' for easy reference.
	- Create an inventory transfer with the french customer as contact
	- Add the product that you created
	- Print > Delivery Slip

	The report will show in the lines:
	"""
	French product name
	English product name
	"""

Cause

	Getting product description without checking partner language.

Solution

	If partner is set, get product description with partner language in context.

opw-2280490

closes odoo/odoo#53977

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Fix discount indicator with 100.0% discount.
- Fix reported tax amount with group of taxes.
- Fix reported tax_base_amount with foreign currency.
- Fix invoice summary according the facturx xsd.

closes odoo/odoo#53895

Related: odoo/enterprise#11606
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

fine-tuning of bf8a9af1

- Employees > Configuration > Activity Planning > Plans and ensure the
  activities have different responsible;
- Create a new Employee, assign a Manager (a different user then the one
  connected, you can assign Marc Demo for example);
- Click launch plan.

Before this commit, the activity type responsible is ignored and the
responsible for all activities is the connected user.

Now, the responsible for the activities are assigned taking into account
the activity type configuration.

opw-2265631

closes odoo/odoo#54033

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

If no country is specified on a partner, self.country_id is
res.country() and partner_country_code contains res.country(). In the
next line the code was comparing `res.country()` with `'BE'`, raising
a warning.

closes odoo/odoo#54020

X-original-commit: ef9fc11d
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

- Activate more than one language
- Install sale_quotation_builder
- Create a new quotation model without website description
- Create a SO using this model, Save

The 'Please update translations of' is displayed for the website
desctiption, although it is empty: when clicking on the link, no record
is shown.

This happens because an empty HTML field always contains at least
`<p><br></p>`.

We do not consider the latter string for translation.

opw-2274203

closes odoo/odoo#53998

X-original-commit: 86741c65
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Ensure deterministic sorting for slides with the same sequence.

opw-2283154

closes odoo/odoo#53996

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before that, since https://github.com/odoo/odoo/commit/71ee252dc43fd0e2b86ba8079c31915544e528eb , negative invoice lines were not supported by thoses taxes. Nor were miscellaneous entries. To make them work, we change the way tags are assigned to cash basis taxes : instead of copying them from the invoice, sign included, we now change their sign when appropriate, so that the resulting cash basis move can be treated like any regular miscellaneous operation by the tax report (so, always applying a factor of 1 to its lines' balance).

Doing that also allows us to re-simplify the code used in the tax report and tax audit computation to manage cash basis entries, and makes the cash basis entry more standard. This is also a usability improvement: now the user does not have to search for the original invoice to understand how the CABA entries are going to impact the report: it's always managed like a misc. operation, so he can just trust the signs of the tags.

v13 version of https://github.com/odoo/odoo/pull/53085



closes odoo/odoo#53503

Related: odoo/enterprise#11372
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Create an invoice, fill document type
"(61) Nota de Crédito Electrònica". Save.
Action will be blocked by a warning: document type is invalid.

Some options in the document type should not be shown as they can not be
used in the customer invoices and customer credit note.

opw-2286623

closes odoo/odoo#53971

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:
- install website, website_mass_mailing
- go to website, edit and add a popup window (you should see warning banner stating
that a newsletter popup is present on this window). Save.
- go to settings > languages > load a new language (fr_FR for example) and translate
the website
- go back to the website > select the new language > click the TRANSLATE button

Previous behavior:
the warning banner is not editable, also click the "Edit popup" button does nothing

Current behavior:
clicking the "Edit popup" button triggers an alert with
a quick explanatory text

opw-2280188

closes odoo/odoo#53557

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Trying to call display_refresh or update_url when no screen was
connected to the IoT Box and the default distant_display was created
resulted in an error.

closes odoo/odoo#53967

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

In case the COA is imported in the system, the `chart_template_id` of
the company remains empty while the accounting is usable. However, in
this case it's impossible to open a POS session.

We leave the warning in the POS config but avoid blocking the user.

opw-2286640

closes odoo/odoo#53963

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

It can happen that a partner has no name, we should not crash and leave it empty instead.

closes odoo/odoo#53903

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this fix, the search on the supplierinfo had
an undeterministic result.

When testing odoo/addons/purchase_stock/tests/test_reordering_rule.py:66
`def test_procure_not_default_partner`, it may fail at line 120.
It sets 2 suppliers:
- Firstly, the `default_vendor` (let's assume id=120)
- Then, the `secondary_vendor` (let's assume id=121)

It then runs a procurement without setting the supplier and assert
that the partner of the resulting PO line should be `default_vendor`.

The return of
odoo/addons/product/models/product.py:574
`def _prepare_sellers` depends on Postgres when the supplierinfo
sequence, min_qty and price are the same for multiple records.

By adding the `id` to the `.sorted`, the result will order correctly in that
case.

opws-2272627
    -2282081
    -2287079
And PS-BE via CSC reported more cases without opw.

closes odoo/odoo#53939

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Select a sales order.
Go to action > generate payment link.
Open private browser, reach the link.

User will receive error message because of access denied to the
res.partner data.

opw-2287534

closes odoo/odoo#53910

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

	- Install 'Accounting' app
	- Create tax A and tax B for 5%, make sure they are NOT included in price
	- Create a tax C as a group that includes Tax A and B
	- Go to any bank journal and create a statement line for 100 dlls
	- Click Reconcile
	- Select Manual Operations
	- Select any account
	- Add Tax C
	- Check on 'Tax Included in Price'

	Wrong calculation.

Cause

	Not considering forced 'Tax Included in Price'
	('force_price_include'),when cumulating tax included
	amount.

opw-2280714

closes odoo/odoo#53906

X-original-commit: ef63297fa2513a58b4dd6db7f44a46643decce66
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Write is overridden on reserved move lines to make sure the quants are
correctly updated. It is divided in two parts: if you update the reserved
quantity and if you update a characteristic. If somehow both are updated
in the same call (which doesn't happen in the standard interface), then
the quants are unreserved two times, which is wrong.

This issue showcased by [0] and on databases where the reserved
quantities are made editable by customization.

We grouped the two update in one, such as the TODO indicated us since a
long, long time.
We removed `result_packaged_id` from the trigger because it should not
impact the reservation whatsoever.
We needed to remove a tricky logic in the stock move's backordering part
but it was fishy anyway.

[0] eac8c06e

closes odoo/odoo#53794

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Go to Payments view
Select multiple confirmed payments, click on Actions>Send receipt by
email

Only for the first payment will be sent an email.
This occur because in composition mode 'comment' (the default)
mail composer sens the mail to a single record
Adding a duplicate action to handle multi send
Updating translation accordingly

opw-2278971

closes odoo/odoo#53725

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Previously, duplicating a block inside of the newsletter popup would
cause the subscribe input and button to disappear. Actually, it
disappears when you use most options of the left panel, because
selecting an option refreshes the public widgets, which destroys them
and starts them again, but for some reason, the subscribe widget's
destroy method makes it d-none, but only removes that class if the
subscribe input is not inside of a modal.

This commit fixes that by not using d-none on the subscribe input group
at all. We keep the d-none removals for databases which may have the
button saved in a disabled state.

task-2244780

closes odoo/odoo#50286

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

opws: 2269230, 2248760
When a database has a lot of projects with many tasks, and needs
to send a lot of feedback mails, the cron tries to send mails to
all tasks at the same time, thus it times out.

This fix will allow to treat projects one at a time so that when
the cron times out, it will not restart from the beginning.

closes odoo/odoo#53896

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#38301

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

In case a field is limited to specific groups on the model, those fields
are discarded from `fields_view_get()` but can still be referenced by some
filters on the search view causing a traceback (see #53797)

Model:

```python

class MyModel(models.Model):

  my_field = fields.Char(groups='base.group_system')
```

Search views:

```xml
<search string="My Model">
    <filter name="group_myfield" context="{'group_by': 'my_field'}"/>
</search>
```

This commit ensure those filter are correctly discarded.

OPW-2284621

closes odoo/odoo#53886

X-original-commit: 6a1eb6d332c5a9bcb9f1d2d1034e6640f5cd2317
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Xavier ALT <xavieralt@users.noreply.github.com>

Steps to reproduce the bug:

- Let's consider a fixed tax T of 5€
- Create a customer invoice with one line L
- Set T on L and 100% discount on L

Bug:

A tax of -5€ was due by the customer (meaning the seller must return
5€ to the customer)

opw:2283875

closes odoo/odoo#53788

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

- Install Accounting, Point of Sale
- Go to Accounting > Configuration > Taxes
- Create 2 taxes (e.g. Tax 15% and Tax 21%)
- Go to Accounting > Configuration > Fiscal Positions
- Create a new Fiscal Postion with the following line for Tax Mapping:
  * Tax on Product: Tax 21%
  * Tax to Apply: Tax 15%
- Go to Point of Sale > Products > Products
- Create a new Product (e.g. Test Product) with "Tax 15%" and "Tax 21%" in Customer Taxes
(Make sure that the Tax 15% is the same than the one for the "Tax to Apply" in the Fiscal Position)
- Go to Point of Sale and configure a POS:
  * Activate "Fiscal Position per Order" and choose the created Fiscal Position
  * Add Bank as Payment Method
- Start a POS session
- Search "Test Product" and add it
- Click on Tax button and select the created Fiscal Position
- Proceed to payment
- Choose Bank and validate
- Exit the POS session
- Click on "CLOSE" and "VALIDATE CLOSING & POST ENTRIES"
An error message appeared with the following message: "Cannot create unbalanced journal entry"

When closing and posting entries, an account move and account move lines are created from the session orders.
For each order lines, taxes are computed from taxes on product and fiscal position of the order.
In this case, the product has 2 taxes applied (Tax 15% and Tax 21%).
Due to the chosen Fiscal Position, the Tax 15% is applied instead of Tax 21%.
For the order line, Tax 15% is applied 2 times.
But during the account move lines generation, the original Tax 15% and the converted Tax 15% are merged together,
because they represent the same tax (same model id).
So the Tax 15% is only applied once, which results on unbalanced amounts during reconciliation.

In Sales, for the same case, the tax is only applied once.
To stay consistent with Sales behavior, the tax will also be applied once in Point of Sale.

opw-2278826

closes odoo/odoo#53549

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Create some attributes with "create dynamically" set
Create a product template using these attributes (=> product variants
should not be created)
Set this product as manufactured, and create an associated BOM with some
components
Try to print the BOM

User will face a traceback due to the product_id being non existant

opw-2283649

closes odoo/odoo#53854

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

A product can't be archived if it's used in a pos loyalty program.

opw-2276745

closes odoo/odoo#53786

Related: odoo/enterprise#11472
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

- Create an invoice with a Product X and Post it;
- Generate a Credit Note from the invoice;
- Reporting > Invoices;
- use Pivot Table View;
- Enable 'Product Quantity' in Measures;
- Filter by 'Invoice #';
- Expand Pivot Table by 'Product'.

Before this commit, the products in the credit note had a positive sign,
contrary to the untax total that has a negative sign. The issue with
this, is when the quantities of the credit notes is added with the
quantities of the invoices the total is not coherent with the actual
sell products.

Now, the product quantity that comes from a credit note has a negative
sign. This was already the behaviour in version 11 and 12.

opw-2283833

closes odoo/odoo#53795

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

Done at odoo/odoo#53561

closes odoo/odoo#53845

X-original-commit: e4bef56c
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Commit 4c4adf47 fixed the `pos_discount` installation in
case of a session is already opened. However, this breaks the following
condition:

https://github.com/odoo/odoo/blob/8aa952d18acca5a0ac3b32579e812158e641c13c/addons/point_of_sale/views/point_of_sale_dashboard.xml#L67



The `current_session_id` is always filled in for any user, so the badge
is not shown anymore.

We can keep the same logic than the mentioned commit but without
impacting the computation of `current_session_id`.

closes odoo/odoo#53412

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Create a new POS session with User A
- Make an order
- Logout and connect as User B
- Resume the session

The session cannot be resumed and the user is redirected to the POS
Dashboard.

When searching for a session to resume, the search restricts the user to
the current user. Therefore, no session is found.

If no session is found, we search on sessions corresponding to the given
configuration. The configuration is mandatory to avoid being redirected
to a random session.

opw-2274973

This fix will complete the task 1965890 by allowing the user with
access rights to edit fields (reference, account_id, taxes_ids
& analytic_account_id) depending the sheet state.

Also added Tests to check if access rights on expense lines are
working well depending on the expense.sheet.state and the user group.

Task ID 2226352

closes odoo/odoo#48870

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

- Create a repair order
- Choose a customer A
- Change the invoicing address to customer B > set default
- Create invoice

The delivery address set on the repair order is not taken into account
on the invoice. The delivery address field on the invoice stays empty
despite having a delivery address set up on the repair order.

opw-2285659

closes odoo/odoo#53747

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:

- Let's consider a user U with no access to hr.attendance
- Let's consider that U has made some check in and check out
- Log with U
- Go to your profile and on Last month

Bug:

U can modifiy manually his attendances.

opw:2279682

closes odoo/odoo#53801

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Issue

	- Turn on Sales Product Configurator
	- Create a product template with an attribute and an attribute value defined as "is custom".
	- Create a new quote, add the template, and configure the product, entering a custom value.
	- Save.
	- Duplicate the Quote

	Custom value missing.

Cause

	Custom value (field product_custom_attribute_value_ids) not duplicated.

Solution

	Add attribute 'copy=True' to field product_custom_attribute_value_ids.

opw-2279933

closes odoo/odoo#53800

X-original-commit: 7ea6798f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

	- Install eCommerce, Stripe
	- Setup stripe for testing
	- Order something
	- Open stripe payment interface (not with odoo)
	- Go back with the stripe interface button

	Order Cancelled

	- Go back with browser back button
	- Enter your data

	Can pay but order still cancelled so
	you paid for nothing

Cause

	I fixed a linked error in
	b8b9a04f

	but I didn't mind that we should cancel
	the stripe payment intent too

Solution

	Cancel the stripe payment intent so that
	filling the stripe form by following
	those step will returns an error from
	stripe

OPW-2282946

closes odoo/odoo#53737

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#53799

Taskid: 2219194
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#53530

X-original-commit: bb48687c7c7bc1aa0f9f96acf37d2537d550ac0f
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

The string formating was called inside _() which does not work.

closes odoo/odoo#53775

X-original-commit: aef420570ca153da34796a80d3e22193f17c2cf0
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>