Skip to content
Snippets Groups Projects
  1. Mar 11, 2020
  2. Mar 10, 2020
  3. Mar 11, 2020
    • Sébastien Theys's avatar
      [FIX] mail_bot: revert of notification request change · db6a018c
      Sébastien Theys authored
      
      Commit [1] does not work as it is supposed to, because there has been a
      confusion between the "notification request" and the "chat with OdooBot".
      
      `_showOdoobotTimeout` is for the chat, and it is unrelated to the notification
      request. We don't want to initiate multiple chats with OdooBot so that has to be
      reverted.
      
      As for the original goal of the PR about the notification request, it wasn't met
      either because it is the browser controlling it:
      
      - on Firefox there simply isn't a "close" button, and closing it by any other
        means (escape key) is considered as a denied.
      
      - on Chrome, when closing it for the first time, it will appear again
        automatically after the next page reload, so no additional code is required.
        However, if it is closed too many times (around 3) it will become
        automatically denied too, at the browser level.
      
      The only thing to do at that point is to better notify the user that it was
      blocked, without being intrusive, which is the focus of task-2188584.
      
      [1] b7254eca
      
      opw-2186299
      
      closes odoo/odoo#47395
      
      X-original-commit: 50155e80
      Signed-off-by: default avatarSébastien Theys (seb) <seb@odoo.com>
      db6a018c
    • Swapnesh Shah's avatar
      [FIX] sale,payment: Encode Payment URL correctly · cf42c2e2
      Swapnesh Shah authored
      
      Before this commit, Payment URL was not encoded correctly which can compute Payment refernece Wrongly on website.
      
      Eg,
        Enter Description which contains Special Characters
        Go to Payment Page using Computed URL.
        There will be wrong Payment Reference on Payment page.
      
      With this commit, We encode Payment reference before generating Payment URL.
      
      closes odoo/odoo#47387
      
      X-original-commit: 6ebcc43d
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      cf42c2e2
    • Xavier Morel's avatar
      [IMP] core: only check for the unaccent function to enable the feature · b6af34d3
      Xavier Morel authored
      
      Before this the `--unaccent` flag does double duty to specify whether
      to create new databases with the extension *and* to try to use the
      corresponding function.
      
      The latter is further gated on the function existing at all in the
      database.
      
      Given postgresql does not have unaccent installed by default it seems
      only the latter is really useful and we can ignore the flag to decide
      whether to enable unaccent features, if the extension is installed
      consider that it should be enabled and move on.
      
      Merge this in master rather than previous versions as it can change
      things like index access / use.
      
      closes odoo/odoo#47377
      
      Signed-off-by: default avatarXavier Morel (xmo) <xmo@odoo.com>
      b6af34d3
    • jvm-odoo's avatar
      [FIX] mail: attachments in the message when marking activity as done · 06dee038
      jvm-odoo authored
      
      Fine tuning of 1e411e3a6d
      - It moves the attachment in the message when we mark an activity as
        done.
      - It adds a test
      
      OPW-2196668
      
      closes odoo/odoo#47349
      
      X-original-commit: 2033066426a6af6eed5f80f1bcde6e650e998f0d
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      06dee038
    • Nicolas Martinelli's avatar
      [FIX] point_of_sale: rounding error · 4aa7e101
      Nicolas Martinelli authored
      
      - Set 'Product Unit of Measure' to 5
      - Set the UoM rounding to 0.001
      - Create an excluded tax of 6 %
      - Create a product costing 7.0
      - Open the POS, add the product with a quantity of 0.535
      
      The tax is 0.22 instead of 0.23.
      
      The root cause of the issue is the in JS:
      
      ```
      round_pr(0.535, Math.pow(10,-5)) * 7 = 3.744999999999999
      round_pr(0.535, 0.00001) * 7 = 3.745
      ```
      
      The numerical error impacts the tax computation later on.
      
      As a workaround, we round by the maximum between the UoM rounding and
      the 'Product Unit of Measure', which is what will be done in the backend
      anyway.
      
      opw-2205092
      
      closes odoo/odoo#47372
      
      X-original-commit: 125cdf96
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      4aa7e101
  4. Mar 10, 2020
  5. Mar 11, 2020
  6. Mar 04, 2020
  7. Mar 06, 2020
  8. Mar 10, 2020
  9. Mar 05, 2020
  10. Mar 10, 2020
Loading